Skip to content

Conversation

@zwangsheng
Copy link
Contributor

What changes were proposed in this pull request?

Adjust the log logic of CoarseGrainedExecutorBackend

Why are the changes needed?

When exit executor with system code 0, coarseGrainedExecutorBackend will print ERROR log.
That doesn't make sense, because it seems to me that executor's normal decommission is not caused by an exception.

Does this PR introduce any user-facing change?

no

How was this patch tested?

local

@github-actions github-actions bot added the CORE label Aug 12, 2021
@HyukjinKwon
Copy link
Member

can you file a JIRA please? Also it would be great to show the console output you got from the manual test.

@zwangsheng
Copy link
Contributor Author

can you file a JIRA please? Also it would be great to show the console output you got from the manual test.

OK, i will do it later.

@zwangsheng zwangsheng changed the title [CORE] modify exit executor log logic [SPARK-36487] [CORE] modify exit executor log logic Aug 12, 2021
@HyukjinKwon HyukjinKwon changed the title [SPARK-36487] [CORE] modify exit executor log logic [SPARK-36487][CORE] Modify exit executor log logic Aug 12, 2021
@zwangsheng
Copy link
Contributor Author

Write a unit tests to reflect exitExecutor method

popo_2021-08-12  18-11-16

Using code 0 can print info log

POPO20210812-181011

@zwangsheng
Copy link
Contributor Author

Please take a check, thank you. @HyukjinKwon

@yaooqinn
Copy link
Member

ok to test

@SparkQA
Copy link

SparkQA commented Aug 13, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46934/

@Ngone51
Copy link
Member

Ngone51 commented Aug 13, 2021

Strictly speaking, I think this should be a user-facing change.

Copy link
Member

@Ngone51 Ngone51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable to me.

@SparkQA
Copy link

SparkQA commented Aug 13, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46934/

@SparkQA
Copy link

SparkQA commented Aug 13, 2021

Test build #142427 has finished for PR 33718 at commit 357ba65.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142427/

Copy link
Member

@yaooqinn yaooqinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srowen
Copy link
Member

srowen commented Aug 13, 2021

Merged to master

@srowen srowen closed this in 46f56e6 Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants