-
Notifications
You must be signed in to change notification settings - Fork 29.1k
[SPARK-36487][CORE] Modify exit executor log logic #33718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
can you file a JIRA please? Also it would be great to show the console output you got from the manual test. |
OK, i will do it later. |
|
Please take a check, thank you. @HyukjinKwon |
|
ok to test |
|
Kubernetes integration test starting |
|
Strictly speaking, I think this should be a user-facing change. |
Ngone51
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds reasonable to me.
|
Kubernetes integration test status success |
|
Test build #142427 has finished for PR 33718 at commit
|
|
Refer to this link for build results (access rights to CI server needed): |
yaooqinn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Merged to master |


What changes were proposed in this pull request?
Adjust the log logic of CoarseGrainedExecutorBackend
Why are the changes needed?
When exit executor with system code 0, coarseGrainedExecutorBackend will print ERROR log.
That doesn't make sense, because it seems to me that executor's normal decommission is not caused by an exception.
Does this PR introduce any user-facing change?
no
How was this patch tested?
local