[SPARK-36538][DOCS] Fix the environment variables part in configuration.md#33777
Closed
yutoacts wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-36538][DOCS] Fix the environment variables part in configuration.md#33777yutoacts wants to merge 1 commit intoapache:masterfrom
yutoacts wants to merge 1 commit intoapache:masterfrom
Conversation
|
Can one of the admins verify this patch? |
yutoacts
changed the title
yutoacts
changed the title
yutoacts
changed the title
sarutak
reviewed
Aug 18, 2021
| Since `spark-env.sh` is a shell script, some of these can be set programmatically -- for example, you might | ||
| compute `SPARK_LOCAL_IP` by looking up the IP of a specific network interface. | ||
|
|
||
| Note: When running Spark on YARN in `cluster` mode, environment variables need to be set using the `spark.yarn.appMasterEnv.[EnvironmentVariableName]` property in your `conf/spark-defaults.conf` file. Environment variables that are set in `spark-env.sh` will not be reflected in the YARN Application Master process in `cluster` mode. See the [YARN-related Spark Properties](running-on-yarn.html#spark-properties) for more information. |
Member
There was a problem hiding this comment.
Hmm, env vars in spark-env.sh are still not reflected in the YARN AM right?
Contributor
Author
There was a problem hiding this comment.
I think I totally misunderstood what it says.. Thank you for the correction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove incorrect documentation about environment variables on YARN cluster mode from configuration.md.
Why are the changes needed?
The documentation said that environment variables are not reflected through spark-env.sh in YARN cluster mode but I believe they are regardless of deploy-mode.
Does this PR introduce any user-facing change?
Yes, docs changed.
How was this patch tested?
SKIP_API=1 bundle exec jekyll build