Skip to content

[SPARK-36552][SQL] Fix different behavior for writing char/varchar to hive and datasource table #33798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yaooqinn wants to merge 2 commits into from
Closed

[SPARK-36552][SQL] Fix different behavior for writing char/varchar to hive and datasource table #33798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f33ca39
[SPARK-36552][SQL] Fix different behavior for writing char/varchar to…
yaooqinn Aug 20, 2021
c4d25aa
ci
yaooqinn Aug 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -999,8 +999,11 @@ private[hive] object HiveClientImpl extends Logging {
// For Hive Serde, we still need to to restore the raw type for char and varchar type.
// When reading data in parquet, orc, or avro file format with string type for char,
// the tailing spaces may lost if we are not going to pad it.
val typeString = CharVarcharUtils.getRawTypeString(c.metadata)
.getOrElse(c.dataType.catalogString)
val typeString = if (SQLConf.get.charVarcharAsString) {
c.dataType.catalogString
} else {
CharVarcharUtils.getRawTypeString(c.metadata).getOrElse(c.dataType.catalogString)
}
new FieldSchema(c.name, typeString, c.getComment().orNull)
}

Expand Down
14 changes: 14 additions & 0 deletions sql/hive/src/test/scala/org/apache/spark/sql/HiveCharVarcharTestSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,20 @@ class HiveCharVarcharTestSuite extends CharVarcharTestSuite with TestHiveSinglet
checkAnswer(sql("SELECT v from t where c = 'Spark' and v = 'kyuubi'"), Row("kyuubi"))
}
}

test("SPARK-36552: Fix different behavior of writing char/varchar to hive and datasource table") {
Seq("true", "false").foreach { v =>
withSQLConf(
"spark.sql.hive.convertMetastoreParquet" -> v,
"spark.sql.legacy.charVarcharAsString" -> "true") {
withTable("t") {
sql(s"CREATE TABLE t (c varchar(2)) USING $format")
sql("INSERT INTO t SELECT 'kyuubi'")
checkAnswer(sql("SELECT c from t"), Row("kyuubi"))
}
}
}
}
}

class HiveCharVarcharDDLTestSuite extends CharVarcharDDLTestBase with TestHiveSingleton {
Expand Down