[SPARK-36374][FOLLOW-UP] Change config key spark.shuffle.server.mergedShuffleFileManagerImpl to spark.shuffle.push.server.mergedShuffleFileManagerImpl #33799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
|
Ok to test |
mridulm
approved these changes
Aug 20, 2021
Contributor
|
+CC @gengliangwang, @Ngone51 We should get this into branch-3.2 as well. |
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Test build #142676 has finished for PR 33799 at commit
|
HyukjinKwon
changed the title
HyukjinKwon
approved these changes
Aug 22, 2021
Member
|
We should technically wait for RC 1 to fail before merging .... although typically RC1 would very very likely fail .. :-). |
Contributor
|
RC.1 does not include #33790, which results in test failure - so it will unfortunately fail. |
asfgit
pushed a commit
that referenced
this pull request
Aug 22, 2021
…dShuffleFileManagerImpl to spark.shuffle.push.server.mergedShuffleFileManagerImpl ### What changes were proposed in this pull request? Minor changes to change the config key name from `spark.shuffle.server.mergedShuffleFileManagerImpl` to `spark.shuffle.push.server.mergedShuffleFileManagerImpl`. This is missed out in #33615. ### Why are the changes needed? To keep the config names consistent ### Does this PR introduce _any_ user-facing change? Yes, this is a change in the config key name. But the new config name changes are yet to be released. Technically there is no user facing change because of this change. ### How was this patch tested? Existing tests. Closes #33799 from venkata91/SPARK-36374-follow-up. Authored-by: Venkata krishnan Sowrirajan <vsowrirajan@linkedin.com> Signed-off-by: Mridul Muralidharan <mridul<at>gmail.com> (cherry picked from commit 7b2842e) Signed-off-by: Mridul Muralidharan <mridulatgmail.com>
Contributor
|
Merged to master and branch-3.2 Thanks for fixing this @venkata91 ! |
Member
|
Late +1 |
venkata91
added a commit
to linkedin/spark
that referenced
this pull request
Oct 13, 2021
…dShuffleFileManagerImpl to spark.shuffle.push.server.mergedShuffleFileManagerImpl Minor changes to change the config key name from `spark.shuffle.server.mergedShuffleFileManagerImpl` to `spark.shuffle.push.server.mergedShuffleFileManagerImpl`. This is missed out in apache#33615. To keep the config names consistent Yes, this is a change in the config key name. But the new config name changes are yet to be released. Technically there is no user facing change because of this change. Existing tests. Closes apache#33799 from venkata91/SPARK-36374-follow-up. Authored-by: Venkata krishnan Sowrirajan <vsowrirajan@linkedin.com> Signed-off-by: Mridul Muralidharan <mridul<at>gmail.com> (cherry picked from commit 7b2842e) Signed-off-by: Mridul Muralidharan <mridulatgmail.com>
wangyum
pushed a commit
that referenced
this pull request
May 26, 2023
…dShuffleFileManagerImpl to spark.shuffle.push.server.mergedShuffleFileManagerImpl Minor changes to change the config key name from `spark.shuffle.server.mergedShuffleFileManagerImpl` to `spark.shuffle.push.server.mergedShuffleFileManagerImpl`. This is missed out in #33615. To keep the config names consistent Yes, this is a change in the config key name. But the new config name changes are yet to be released. Technically there is no user facing change because of this change. Existing tests. Closes #33799 from venkata91/SPARK-36374-follow-up. Authored-by: Venkata krishnan Sowrirajan <vsowrirajan@linkedin.com> Signed-off-by: Mridul Muralidharan <mridul<at>gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Minor changes to change the config key name from
spark.shuffle.server.mergedShuffleFileManagerImpltospark.shuffle.push.server.mergedShuffleFileManagerImpl. This is missed out in #33615.Why are the changes needed?
To keep the config names consistent
Does this PR introduce any user-facing change?
Yes, this is a change in the config key name. But the new config name changes are yet to be released. Technically there is no user facing change because of this change.
How was this patch tested?
Existing tests.