[SPARK-34952][SQL][FOLLOWUP] Change column type to be NamedReference#33927
Closed
huaxingao wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-34952][SQL][FOLLOWUP] Change column type to be NamedReference#33927huaxingao wants to merge 1 commit intoapache:masterfrom
huaxingao wants to merge 1 commit intoapache:masterfrom
Conversation
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
Contributor
Author
|
Test build #143057 has finished for PR 33927 at commit
|
viirya
approved these changes
Sep 8, 2021
Member
|
"Fix problem" sounds too general. :) @huaxingao Maybe add a few words there? |
cloud-fan
approved these changes
Sep 8, 2021
Contributor
yea, should be something like |
HyukjinKwon
approved these changes
Sep 8, 2021
Contributor
|
thanks, merging to master/3.2! |
cloud-fan
pushed a commit
that referenced
this pull request
Sep 8, 2021
### What changes were proposed in this pull request? Currently, we have `FieldReference` for aggregate column type, should be `NamedReference` instead ### Why are the changes needed? `FieldReference` is a private class, should use `NamedReference` instead ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? existing tests Closes #33927 from huaxingao/agg_followup. Authored-by: Huaxin Gao <huaxin_gao@apple.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit 23794fb) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Contributor
Author
|
Thanks all! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, we have
FieldReferencefor aggregate column type, should beNamedReferenceinsteadWhy are the changes needed?
FieldReferenceis a private class, should useNamedReferenceinsteadDoes this PR introduce any user-facing change?
No
How was this patch tested?
existing tests