Skip to content

[SPARK-36739][DOCS][PYTHON] Add apache license headers to makefiles#33979

Closed
yoda-mon wants to merge 1 commit intoapache:masterfrom
yoda-mon:add-license-header-makefiles
Closed

[SPARK-36739][DOCS][PYTHON] Add apache license headers to makefiles#33979
yoda-mon wants to merge 1 commit intoapache:masterfrom
yoda-mon:add-license-header-makefiles

Conversation

@yoda-mon
Copy link
Contributor

@yoda-mon yoda-mon commented Sep 13, 2021 •
edited
Loading

What changes were proposed in this pull request?

Add apache license headers to makefiles of PySpark documents.

Why are the changes needed?

Makefiles of PySpark documentations do not have apache license headers, while the other files have.

Does this PR introduce any user-facing change?

No

How was this patch tested?

make html on both Linux and Windows

yoda-mon
yoda-mon commented Sep 13, 2021
View reviewed changes
python/docs/make.bat
@@ -1,4 +1,21 @@
@ECHO OFF
@echo off

Copy link
Contributor Author

@yoda-mon yoda-mon Sep 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spark/bin/pyspark.cmd uses lower case, so I follow it here.

yoda-mon
yoda-mon commented Sep 13, 2021
View reviewed changes
python/docs/make2.bat

REM Command file for Sphinx documentation
@echo off

Copy link
Contributor Author

@yoda-mon yoda-mon Sep 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spark/bin/pyspark.cmd uses lower case, so I follow it here.

@sarutak
Copy link
Member

sarutak commented Sep 13, 2021

ok to test.

@yoda-mon yoda-mon mentioned this pull request Sep 13, 2021
Closed
@SparkQA
Copy link

SparkQA commented Sep 13, 2021

Test build #143203 has finished for PR 33979 at commit 51ad83f.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 13, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47705/

@SparkQA
Copy link

SparkQA commented Sep 13, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47705/

@sarutak
Copy link
Member

sarutak commented Sep 13, 2021

retest this please.

@SparkQA
Copy link

SparkQA commented Sep 13, 2021

Test build #143209 has finished for PR 33979 at commit 51ad83f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 13, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47709/

@SparkQA
Copy link

SparkQA commented Sep 13, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47709/

@sarutak
Copy link
Member

sarutak commented Sep 13, 2021

@yoda-mon You changed bat files so it's better to ensure that we can successfully build the docs on Windows. Did you confirm that?
If so, could you note in the description that you confirmed make html on both Linux and Windows?

@holdenk
Copy link
Contributor

holdenk commented Sep 13, 2021

Since this is a missing license issue is it a blocker?

@AmplabJenkins
Copy link

AmplabJenkins commented Sep 13, 2021

Can one of the admins verify this patch?

@HyukjinKwon
Copy link
Member

HyukjinKwon commented Sep 14, 2021

Merged to master and branch-3.2.

HyukjinKwon pushed a commit that referenced this pull request Sep 14, 2021
@yoda-mon @HyukjinKwon
[SPARK-36739][DOCS][PYTHON] Add apache license headers to makefiles
b3488a5 
### What changes were proposed in this pull request?

Add apache license headers to makefiles of PySpark documents.

### Why are the changes needed?

Makefiles of PySpark documentations do not have apache license headers, while the other files have.

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

`make html`

Closes #33979 from yoda-mon/add-license-header-makefiles.

Authored-by: Leona Yoda <yodal@oss.nttdata.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit a440025)
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
@sarutak
Copy link
Member

sarutak commented Sep 14, 2021

@holdenk

Since this is a missing license issue is it a blocker?

Yeah, I think so.

@yoda-mon
Copy link
Contributor Author

yoda-mon commented Sep 14, 2021

@yoda-mon You changed bat files so it's better to ensure that we can successfully build the docs on Windows. Did you confirm that?
If so, could you note in the description that you confirmed make html on both Linux and Windows?

I did both of them, so I will change the discription like make html on boh Linux and Windows. Thank you.

@HyukjinKwon
Copy link
Member

HyukjinKwon commented Sep 14, 2021 •
edited
Loading

Oops, I just noticed that I merged it without seeing the comment above #33979 (comment). Good that the comment was addressed after the merge though 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarutak sarutak sarutak approved these changes

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

Assignees

No one assigned

Labels

PYTHON

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@yoda-mon @sarutak @SparkQA @holdenk @AmplabJenkins @HyukjinKwon