Skip to content

[SPARK-36961][PYTHON] Use PEP526 style variable type hints#34227

Closed
ueshin wants to merge 5 commits intoapache:masterfrom
ueshin:issues/SPARK-36961/pep526
Closed

[SPARK-36961][PYTHON] Use PEP526 style variable type hints#34227
ueshin wants to merge 5 commits intoapache:masterfrom
ueshin:issues/SPARK-36961/pep526

Conversation

@ueshin
Copy link
Member

@ueshin ueshin commented Oct 8, 2021

What changes were proposed in this pull request?

Uses PEP526 style variable type hints.

Why are the changes needed?

Now that we have started using newer Python syntax in the code base.
We should use PEP526 style variable type hints.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing tests.

@ueshin
Copy link
Member Author

ueshin commented Oct 8, 2021

cc @zero323 @xinrong-databricks @HyukjinKwon @itholic

@SparkQA
Copy link

SparkQA commented Oct 8, 2021

Test build #144038 has finished for PR 34227 at commit 1068e7d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • new_class = type(NameTypeHolder.short_name, (NameTypeHolder,),

@SparkQA
Copy link

SparkQA commented Oct 8, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48515/

@xinrong-meng
Copy link
Member

Does this PR aim to change pandas API on Spark only?

@SparkQA
Copy link

SparkQA commented Oct 8, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48515/

@zero323
Copy link
Member

zero323 commented Oct 9, 2021

It is awesome @ueshin! Thanks for working on this.

@ueshin
Copy link
Member Author

ueshin commented Oct 11, 2021

@xinrong-databricks

Does this PR aim to change pandas API on Spark only?

This also includes two files in sql module:

  • python/pyspark/sql/pandas/conversion.py
  • python/pyspark/sql/pandas/types.py

@SparkQA
Copy link

SparkQA commented Oct 11, 2021

Test build #144101 has finished for PR 34227 at commit be288e2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 11, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48579/

@SparkQA
Copy link

SparkQA commented Oct 11, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48579/

@SparkQA
Copy link

SparkQA commented Oct 11, 2021

Test build #144105 has finished for PR 34227 at commit 126c89c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 11, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48583/

@SparkQA
Copy link

SparkQA commented Oct 12, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48583/

@SparkQA
Copy link

SparkQA commented Oct 12, 2021

Test build #144158 has finished for PR 34227 at commit 96c2a12.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 12, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48636/

@SparkQA
Copy link

SparkQA commented Oct 12, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48636/

@ueshin ueshin requested review from HyukjinKwon and zero323 October 13, 2021 00:29
@HyukjinKwon
Copy link
Member

Merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants