[WIP][SPARK-36995][SQL] Add SQLFileCommitProtocol#34271
Closed
AngersZhuuuu wants to merge 1 commit intoapache:masterfrom
Closed
[WIP][SPARK-36995][SQL] Add SQLFileCommitProtocol#34271AngersZhuuuu wants to merge 1 commit intoapache:masterfrom
AngersZhuuuu wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
One solution is we can just add below API in FileCommitProtocol then we can complicate history customized FileCommitProtocol and also can implement more function. |
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #144194 has finished for PR 34271 at commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently we use FileCommitProtocol for all insert job, but for SQL part, we should support more strategy such as writing data to stagingdir then remove to target path, with such commit protocol will support more case of DataSource Insert.
I have plan 4 step to do:
getOutputPath&getWorkPathlikePathOutputCommitter, Add SQL related logic to SQLHadoopMapReduceCommitProtocol and make it inherit from SQLCOmmitProtocolWhy are the changes needed?
Make SQL's file commit logic code refactored and support more function
Does this PR introduce any user-facing change?
User's self defined commit protocol for SQL may need to change to inherit from SQLFileCommitProtocol
How was this patch tested?
Exited UT