[SPARK-37052][CORE] Spark should only pass --verbose argument to main class when is sql shell#34322
Closed
AngersZhuuuu wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-37052][CORE] Spark should only pass --verbose argument to main class when is sql shell#34322AngersZhuuuu wants to merge 1 commit intoapache:masterfrom
AngersZhuuuu wants to merge 1 commit intoapache:masterfrom
Conversation
… class when is sql shell
Contributor
Author
Contributor
|
@toujours33 pick this to our branch to verify it please, thanks ~ |
HyukjinKwon
approved these changes
Oct 19, 2021
cloud-fan
approved these changes
Oct 19, 2021
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
Contributor
|
thanks, merging to master/3.2! |
cloud-fan
pushed a commit
that referenced
this pull request
Oct 19, 2021
… class when is sql shell ### What changes were proposed in this pull request? In #32163 spark pass `--verbose` to main class o support spark-sql shell can use verbose argument too. But for other shell main class such as saprk-shell, it's intercepter don't support `--verbose`, so we should only pass `--verbose` for sql shell ### Why are the changes needed? Fix bug ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Closes #34322 from AngersZhuuuu/SPARK-37052. Authored-by: Angerszhuuuu <angers.zhu@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit a6d3a2c) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
|
Test build #144391 has finished for PR 34322 at commit
|
Member
|
+1, LGTM |
sunchao
pushed a commit
to sunchao/spark
that referenced
this pull request
Dec 8, 2021
… class when is sql shell ### What changes were proposed in this pull request? In apache#32163 spark pass `--verbose` to main class o support spark-sql shell can use verbose argument too. But for other shell main class such as saprk-shell, it's intercepter don't support `--verbose`, so we should only pass `--verbose` for sql shell ### Why are the changes needed? Fix bug ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Closes apache#34322 from AngersZhuuuu/SPARK-37052. Authored-by: Angerszhuuuu <angers.zhu@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit a6d3a2c) Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit 34086b0) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
catalinii
pushed a commit
to lyft/spark
that referenced
this pull request
Feb 22, 2022
… class when is sql shell ### What changes were proposed in this pull request? In apache#32163 spark pass `--verbose` to main class o support spark-sql shell can use verbose argument too. But for other shell main class such as saprk-shell, it's intercepter don't support `--verbose`, so we should only pass `--verbose` for sql shell ### Why are the changes needed? Fix bug ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Closes apache#34322 from AngersZhuuuu/SPARK-37052. Authored-by: Angerszhuuuu <angers.zhu@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit a6d3a2c) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
catalinii
pushed a commit
to lyft/spark
that referenced
this pull request
Mar 4, 2022
… class when is sql shell ### What changes were proposed in this pull request? In apache#32163 spark pass `--verbose` to main class o support spark-sql shell can use verbose argument too. But for other shell main class such as saprk-shell, it's intercepter don't support `--verbose`, so we should only pass `--verbose` for sql shell ### Why are the changes needed? Fix bug ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Closes apache#34322 from AngersZhuuuu/SPARK-37052. Authored-by: Angerszhuuuu <angers.zhu@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit a6d3a2c) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In #32163 spark pass
--verboseto main class o support spark-sql shell can use verbose argument too.But for other shell main class such as saprk-shell, it's intercepter don't support
--verbose, so we should only pass--verbosefor sql shellWhy are the changes needed?
Fix bug
Does this PR introduce any user-facing change?
No
How was this patch tested?