[SPARK-4578] fix asDict() with nested Row()#3434
Closed
davies wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-4578] fix asDict() with nested Row()#3434davies wants to merge 1 commit intoapache:masterfrom
davies wants to merge 1 commit intoapache:masterfrom
Conversation
|
Test build #23798 has started for PR 3434 at commit
|
Contributor
|
This looks good to me, pending tests. I tried it out locally in my IPython notebook and it seems to have resolved the blocker that I hit. |
|
Test build #23798 has finished for PR 3434 at commit
|
|
Test PASSed. |
Contributor
|
Thanks - I'm pulling this in. |
Contributor
Author
|
merged |
andrewor14
pushed a commit
to andrewor14/spark
that referenced
this pull request
Nov 25, 2014
The Row object is created on the fly once the field is accessed, so we should access them by getattr() in asDict(0 Author: Davies Liu <davies@databricks.com> Closes apache#3434 from davies/fix_asDict and squashes the following commits: b20f1e7 [Davies Liu] fix asDict() with nested Row() (cherry picked from commit 050616b) Signed-off-by: Patrick Wendell <pwendell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Row object is created on the fly once the field is accessed, so we should access them by getattr() in asDict(0