SPARK-37061: Fix CustomMetrics when using Inner Classes#34344
Closed
RussellSpitzer wants to merge 1 commit intoapache:masterfrom
RussellSpitzer:SPARK-37061
Closed
SPARK-37061: Fix CustomMetrics when using Inner Classes#34344RussellSpitzer wants to merge 1 commit intoapache:masterfrom RussellSpitzer:SPARK-37061
RussellSpitzer wants to merge 1 commit intoapache:masterfrom
RussellSpitzer:SPARK-37061
Conversation
Previously CustomMetrics use Class.getCanonicalName when attempting to get the class name of CustomMetric implementations. These names replace special characters for marking inner classes like ($) with ".". While those names are appropriate for referring to classes withing source files, they will not work during reflection where the Class.getName output should be used.
|
Can one of the admins verify this patch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Previously CustomMetrics use Class.getCanonicalName when attempting to get the
class name of CustomMetric implementations. These names replace special characters
for marking inner classes like ($) with ".". While those names are appropriate for
referring to classes within source files, they will not work during reflection where
the Class.getName output should be used.
Why are the changes needed?
InnerClasses could never be found in when they are used as Custom Metrics
Does this PR introduce any user-facing change?
No
How was this patch tested?
Tests modified so they access both an independent metric class as well as an inner class.