[SPARK-37011][PYTHON] Remove unnecessary 'noqa: F401' comments by ueshin · Pull Request #34385 · apache/spark

ueshin · 2021-10-25T20:04:29Z

What changes were proposed in this pull request?

Remove unnecessary 'noqa: F401' comments.

Why are the changes needed?

Now that flake8 in Jenkins was upgraded (#34384), we can remove unnecessary 'noqa: F401' comments.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing tests.

SparkQA · 2021-10-25T20:07:22Z

Test build #144598 has finished for PR 34385 at commit 44da384.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

ueshin · 2021-10-25T20:17:25Z

Jenkins, retest this please.

SparkQA · 2021-10-25T20:22:43Z

Test build #144599 has finished for PR 34385 at commit 44da384.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2021-10-25T20:50:47Z

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49068/

SparkQA · 2021-10-25T21:02:23Z

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49069/

SparkQA · 2021-10-25T21:35:28Z

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49068/

SparkQA · 2021-10-25T21:46:08Z

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49069/

ueshin · 2021-10-25T23:36:57Z

Jenkins, retest this please.

HyukjinKwon · 2021-10-25T23:58:22Z


./python/pyspark/pandas/_typing.py:25:5: F401 'pyspark.pandas.base.IndexOpsMixin' imported but unused
    from pyspark.pandas.base import IndexOpsMixin
    ^
./python/pyspark/pandas/_typing.py:27:5: F401 'pyspark.pandas.generic.Frame' imported but unused
    from pyspark.pandas.generic import Frame
    ^
2     F401 'pyspark.pandas.base.IndexOpsMixin' imported but unused
2

I think this is because Jenkins users old version of flake8 .. we'll have to find the way to make it compatible with old versions too for now until we drop Jenkins (end of this year).

Otherwise LGTM

SparkQA · 2021-10-26T00:04:33Z

Test build #144600 has finished for PR 34385 at commit 44da384.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2021-10-26T00:46:07Z

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49070/

ueshin · 2021-10-26T00:58:46Z

That's weird. Actually I tried it with flake8==3.9.0 locally and it passes.

% flake8 --version
3.9.0 (mccabe: 0.6.1, pycodestyle: 2.7.0, pyflakes: 2.3.1) CPython 3.9.6 on Darwin

% ./dev/lint-python
starting python compilation test...
python compilation succeeded.

starting black test...
black checks passed.

starting pycodestyle test...
pycodestyle checks passed.

starting flake8 test...
flake8 checks passed.

starting mypy test...
mypy checks passed.


all lint-python tests passed!

SparkQA · 2021-10-26T01:45:11Z

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49070/

dongjoon-hyun

+1 for the PR itself. I'm also not sure about the status of Jenkins.

shaneknapp · 2021-10-26T21:22:47Z

test this please

shaneknapp · 2021-10-26T21:26:33Z

+1 for the PR itself. I'm also not sure about the status of Jenkins.

yeah, that's definitely weird. i ran lint-python manually, as jenkins, on a worker, in an identical environment as the build w/a fresh clone of spark and it passed. let's see what the build i just triggered did

SparkQA · 2021-10-26T21:27:57Z

Test build #144629 has finished for PR 34385 at commit 44da384.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

shaneknapp · 2021-10-26T21:39:13Z

test this please

SparkQA · 2021-10-26T22:06:08Z

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49099/

SparkQA · 2021-10-26T22:10:24Z

Test build #144630 has finished for PR 34385 at commit 44da384.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2021-10-26T22:49:24Z

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49100/

SparkQA · 2021-10-26T22:49:57Z

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49099/

shaneknapp · 2021-10-26T23:04:57Z

yeah, i'm confused as to why this is failing. leave this open, and i'll look in to the underlying failure later this week/early next.

SparkQA · 2021-10-26T23:46:39Z

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49100/

ueshin · 2021-10-27T01:58:45Z

@shaneknapp Thanks for taking a look at this!

shaneknapp · 2021-10-27T16:35:40Z

@shaneknapp Thanks for taking a look at this!

i created a 2nd PR to do some deeper testing of this: #34404

shaneknapp · 2021-10-27T17:14:03Z

i straced lint-python in the other PR and am preparing myself to lose a few brain cells digging through the output later today. :)

https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144666/console

HyukjinKwon · 2021-12-28T01:46:30Z

I think we can merge it now since Jenkins is dropped :-). @ueshin would you mind rebasing this Pr please?

dongjoon-hyun · 2021-12-28T02:18:35Z

+1 for merging, too.

ueshin · 2021-12-28T20:44:55Z

Thanks! merging to master.

Remove unnecessary 'F401' comments.

44da384

github-actions bot added CORE PYTHON labels Oct 25, 2021

ueshin changed the title ~~[SPARK-37011][PYTHON] Remove unnecessary 'F401' comments~~ [SPARK-37011][PYTHON] Remove unnecessary 'noqa: F401' comments Oct 25, 2021

HyukjinKwon approved these changes Oct 25, 2021

View reviewed changes

dongjoon-hyun approved these changes Oct 26, 2021

View reviewed changes

Merge branch 'master' into issues/SPARK-37011/F401

88f7a1d

ueshin closed this in 2b2d722 Dec 28, 2021

Conversation

ueshin commented Oct 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Uh oh!

SparkQA commented Oct 25, 2021

Uh oh!

ueshin commented Oct 25, 2021

Uh oh!

SparkQA commented Oct 25, 2021

Uh oh!

SparkQA commented Oct 25, 2021

Uh oh!

SparkQA commented Oct 25, 2021

Uh oh!

SparkQA commented Oct 25, 2021

Uh oh!

SparkQA commented Oct 25, 2021

Uh oh!

ueshin commented Oct 25, 2021

Uh oh!

HyukjinKwon commented Oct 25, 2021

Uh oh!

SparkQA commented Oct 26, 2021

Uh oh!

SparkQA commented Oct 26, 2021

Uh oh!

ueshin commented Oct 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SparkQA commented Oct 26, 2021

Uh oh!

dongjoon-hyun left a comment

Choose a reason for hiding this comment

Uh oh!

shaneknapp commented Oct 26, 2021

Uh oh!

shaneknapp commented Oct 26, 2021

Uh oh!

SparkQA commented Oct 26, 2021

Uh oh!

shaneknapp commented Oct 26, 2021

Uh oh!

SparkQA commented Oct 26, 2021

Uh oh!

SparkQA commented Oct 26, 2021

Uh oh!

SparkQA commented Oct 26, 2021

Uh oh!

SparkQA commented Oct 26, 2021

Uh oh!

shaneknapp commented Oct 26, 2021

Uh oh!

SparkQA commented Oct 26, 2021

Uh oh!

ueshin commented Oct 27, 2021

Uh oh!

shaneknapp commented Oct 27, 2021

Uh oh!

shaneknapp commented Oct 27, 2021

Uh oh!

HyukjinKwon commented Dec 28, 2021

Uh oh!

dongjoon-hyun commented Dec 28, 2021

Uh oh!

ueshin commented Dec 28, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

ueshin commented Oct 25, 2021 •

edited

Loading

ueshin commented Oct 26, 2021 •

edited

Loading