[SPARK-4596][MLLib] Refactorize Normalizer to make code cleaner#3446
Closed
dbtsai wants to merge 1 commit intoapache:masterfrom
AlpineNow:normalizer
Closed
[SPARK-4596][MLLib] Refactorize Normalizer to make code cleaner#3446dbtsai wants to merge 1 commit intoapache:masterfrom AlpineNow:normalizer
dbtsai wants to merge 1 commit intoapache:masterfrom
AlpineNow:normalizer
Conversation
|
Test build #23824 has started for PR 3446 at commit
|
|
Test build #23824 has finished for PR 3446 at commit
|
|
Test PASSed. |
Contributor
|
LGTM. Merged into master and branch-1.2. Thanks! |
asfgit
pushed a commit
that referenced
this pull request
Nov 25, 2014
In this refactoring, the performance will be slightly increased due to removing the overhead from breeze vector. The bottleneck is still in breeze norm which is implemented by activeIterator. This inefficiency of breeze norm will be addressed in next PR. At least, this PR makes the code more consistent in the codebase. Author: DB Tsai <dbtsai@alpinenow.com> Closes #3446 from dbtsai/normalizer and squashes the following commits: e20a2b9 [DB Tsai] first commit (cherry picked from commit 89f9122) Signed-off-by: Xiangrui Meng <meng@databricks.com>
asfgit
pushed a commit
that referenced
this pull request
Nov 25, 2014
In this refactoring, the performance will be slightly increased due to removing the overhead from breeze vector. The bottleneck is still in breeze norm which is implemented by activeIterator. This inefficiency of breeze norm will be addressed in next PR. At least, this PR makes the code more consistent in the codebase. Author: DB Tsai <dbtsai@alpinenow.com> Closes #3446 from dbtsai/normalizer and squashes the following commits: e20a2b9 [DB Tsai] first commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this refactoring, the performance will be slightly increased due to removing
the overhead from breeze vector. The bottleneck is still in breeze norm
which is implemented by activeIterator.
This inefficiency of breeze norm will be addressed in next PR. At least,
this PR makes the code more consistent in the codebase.