[MINOR][SQL][DOCS] Document JDBC aggregate push down is for DSV2 only#34465
Closed
huaxingao wants to merge 2 commits intoapache:masterfrom
Closed
[MINOR][SQL][DOCS] Document JDBC aggregate push down is for DSV2 only#34465huaxingao wants to merge 2 commits intoapache:masterfrom
huaxingao wants to merge 2 commits intoapache:masterfrom
Conversation
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #144836 has finished for PR 34465 at commit
|
HyukjinKwon
reviewed
Nov 3, 2021
| // This only applies to Data Source V2 JDBC | ||
| val pushDownAggregate = parameters.getOrElse(JDBC_PUSHDOWN_AGGREGATE, "false").toBoolean | ||
|
|
||
| // An option to allow/disallow pushing down LIMIT into JDBC data source |
Contributor
Author
There was a problem hiding this comment.
pushDownLimit is also for DS v2. I will fix the doc in the pushDownSample PR I am currently working on. The reason I want a separate PR to fix JDBC aggregate push down doc is because the fix needs to be in both 3.2 and 3.3. All the other push down (pushDownLimit, pushDownSample, and aggregate push down for parquet and ORC) are for 3.3 only.
HyukjinKwon
changed the title
HyukjinKwon
approved these changes
Nov 3, 2021
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
huaxingao
added a commit
that referenced
this pull request
Nov 3, 2021
### What changes were proposed in this pull request? To specify JDBC aggregate push down is for DS V2 only. This change is for both 3.2 and master. ### Why are the changes needed? To make the doc clear so user won't use aggregate push down in DS v1. ### Does this PR introduce _any_ user-facing change? No. Doc change only ### How was this patch tested? Manually checked. Closes #34465 from huaxingao/doc_minor. Authored-by: Huaxin Gao <huaxin_gao@apple.com> Signed-off-by: Huaxin Gao <huaxin_gao@apple.com> (cherry picked from commit 44151be) Signed-off-by: Huaxin Gao <huaxin_gao@apple.com>
Contributor
Author
|
Merged to 3.2/master. Thanks @HyukjinKwon for reviewing! |
Member
|
+1, LGTM. |
|
Test build #144885 has finished for PR 34465 at commit
|
sunchao
pushed a commit
to sunchao/spark
that referenced
this pull request
Dec 8, 2021
### What changes were proposed in this pull request? To specify JDBC aggregate push down is for DS V2 only. This change is for both 3.2 and master. ### Why are the changes needed? To make the doc clear so user won't use aggregate push down in DS v1. ### Does this PR introduce _any_ user-facing change? No. Doc change only ### How was this patch tested? Manually checked. Closes apache#34465 from huaxingao/doc_minor. Authored-by: Huaxin Gao <huaxin_gao@apple.com> Signed-off-by: Huaxin Gao <huaxin_gao@apple.com> (cherry picked from commit 44151be) Signed-off-by: Huaxin Gao <huaxin_gao@apple.com>
catalinii
pushed a commit
to lyft/spark
that referenced
this pull request
Feb 22, 2022
### What changes were proposed in this pull request? To specify JDBC aggregate push down is for DS V2 only. This change is for both 3.2 and master. ### Why are the changes needed? To make the doc clear so user won't use aggregate push down in DS v1. ### Does this PR introduce _any_ user-facing change? No. Doc change only ### How was this patch tested? Manually checked. Closes apache#34465 from huaxingao/doc_minor. Authored-by: Huaxin Gao <huaxin_gao@apple.com> Signed-off-by: Huaxin Gao <huaxin_gao@apple.com> (cherry picked from commit 44151be) Signed-off-by: Huaxin Gao <huaxin_gao@apple.com>
catalinii
pushed a commit
to lyft/spark
that referenced
this pull request
Mar 4, 2022
### What changes were proposed in this pull request? To specify JDBC aggregate push down is for DS V2 only. This change is for both 3.2 and master. ### Why are the changes needed? To make the doc clear so user won't use aggregate push down in DS v1. ### Does this PR introduce _any_ user-facing change? No. Doc change only ### How was this patch tested? Manually checked. Closes apache#34465 from huaxingao/doc_minor. Authored-by: Huaxin Gao <huaxin_gao@apple.com> Signed-off-by: Huaxin Gao <huaxin_gao@apple.com> (cherry picked from commit 44151be) Signed-off-by: Huaxin Gao <huaxin_gao@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
To specify JDBC aggregate push down is for DS V2 only. This change is for both 3.2 and master.
Why are the changes needed?
To make the doc clear so user won't use aggregate push down in DS v1.
Does this PR introduce any user-facing change?
No. Doc change only
How was this patch tested?
Manually checked.