[SPARK-37223][SQL][TESTS] Fix unit test check in JoinHintSuite#34501
[SPARK-37223][SQL][TESTS] Fix unit test check in JoinHintSuite#34501c21 wants to merge 2 commits intoapache:masterfrom
Conversation
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #144950 has finished for PR 34501 at commit
|
| assert(logs.size == 2) | ||
| logs.forall(_.contains(s"build left for ${joinType.split("_").mkString(" ")} join.")) | ||
| assert(logs.size == 2 && | ||
| logs.forall(_.contains(s"build left for ${joinType.split("_").mkString(" ")} join."))) |
There was a problem hiding this comment.
how about
assert(logs.size == 2)
assert(logs.forall(_.contains(s"build left for ${joinType.split("_").mkString(" ")} join.")))
It might be easier to distinguish which statement is false if something goes wrong.
There was a problem hiding this comment.
Actually maybe even
logs.forall(log => assert(log.contains...))
Also: assert(logs.size === 2)
|
Test build #144958 has finished for PR 34501 at commit
|
|
Jenkins retest this please |
|
Kubernetes integration test starting |
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Kubernetes integration test status failure |
|
Test build #144959 has finished for PR 34501 at commit
|
|
Merged to master |
|
Thank you @srowen and @advancedxy for review! |
5 participants
What changes were proposed in this pull request?
This is to fix the unit test where we should assert on the content of log in
JoinHintSuite.Why are the changes needed?
Improve test.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Changed test itself.