[SPARK-37239][YARN][TESTS][FOLLOWUP] Add UT to cover Client.prepareLocalResources with custom STAGING_FILE_REPLICATION#34531
Closed
LuciferYang wants to merge 2 commits intoapache:masterfrom
Closed
Conversation
Contributor
Author
|
Test build #145021 has finished for PR 34531 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
dongjoon-hyun
approved these changes
Nov 9, 2021
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @LuciferYang .
Merged to master
cc @sunchao
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr add a new UT to cover
o.a.s.deploy.yarn.Client.prepareLocalResourcesmethod with customSTAGING_FILE_REPLICATIONconfiguration and change other related UTs to verify that thereplicationpassed into thecopyFileToRemotemethod isNoneexplicitly.Why are the changes needed?
Add new UT.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass the Jenkins or GitHub Action