Skip to content

[SPARK-37219][SQL][FOLLOWUP] Make AS OF syntax more flexible#34621

Closed
huaxingao wants to merge 2 commits intoapache:masterfrom
huaxingao:asof_followup
Closed

[SPARK-37219][SQL][FOLLOWUP] Make AS OF syntax more flexible#34621
huaxingao wants to merge 2 commits intoapache:masterfrom
huaxingao:asof_followup

Conversation

@huaxingao
Copy link
Contributor

What changes were proposed in this pull request?

Make AS OF syntax more flexible

Why are the changes needed?

((FOR SYSTEM_VERSION) | VERSION) -> FOR? (SYSTEM_VERSION | VERSION) AS OF

Does this PR introduce any user-facing change?

Yes

How was this patch tested?

Existing tests

@github-actions github-actions bot added the SQL label Nov 16, 2021
@huaxingao
Copy link
Contributor Author

cc @cloud-fan @rdblue

@rdblue
Copy link
Contributor

rdblue commented Nov 16, 2021

Thanks, @huaxingao! It would be nice to add tests for the new cases, like FOR VERSION AS OF, but I think that's minor.

@huaxingao huaxingao changed the title [SPARK-37219][SQL] Make AS OF syntax more flexible [SPARK-37219][SQL][FOLLOWUP] Make AS OF syntax more flexible Nov 16, 2021
@SparkQA
Copy link

SparkQA commented Nov 16, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49753/

@SparkQA
Copy link

SparkQA commented Nov 16, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49758/

@SparkQA
Copy link

SparkQA commented Nov 16, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49753/

@SparkQA
Copy link

SparkQA commented Nov 16, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49758/

@SparkQA
Copy link

SparkQA commented Nov 16, 2021

Test build #145283 has finished for PR 34621 at commit 397102b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 16, 2021

Test build #145288 has finished for PR 34621 at commit 93cafdd.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@huaxingao huaxingao closed this in f361ad8 Nov 18, 2021
@huaxingao
Copy link
Contributor Author

Thanks for reviewing! Merged to master.

@huaxingao huaxingao deleted the asof_followup branch November 18, 2021 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants