[SPARK-37352][PYTHON] Silence the index_col advice in to_spark() for internal usage.#34626
Closed
itholic wants to merge 3 commits intoapache:masterfrom
itholic:SPARK-37352
Closed
[SPARK-37352][PYTHON] Silence the index_col advice in to_spark() for internal usage.#34626itholic wants to merge 3 commits intoapache:masterfrom itholic:SPARK-37352
itholic wants to merge 3 commits intoapache:masterfrom
itholic:SPARK-37352
Conversation
HyukjinKwon
approved these changes
Nov 17, 2021
|
Test build #145319 has finished for PR 34626 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
Member
|
Merged to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes adding internal method
_to_spark()to silence the advice log when it's used as an internal purpose.(DataFrame|Series|Index).to_pandas()to reuse the(DataFrame|Series|Index)._to_pandas().Why are the changes needed?
to_spark()without specifyingindex_colparameter is used in many places when implementing API, but users might not want to see the every warnings for internal usage.Showing the advice log when only users explicitly use the
to_spark()without specifyingindex_colparameter is enough.Does this PR introduce any user-facing change?
Reduce the advice log for
_to_spark()without specifyingindex_colparameter.How was this patch tested?
Manually check the result