Skip to content

[SPARK-37389][SQL][3.1] Check unclosed bracketed comments#34696

Closed
beliefer wants to merge 4 commits intoapache:branch-3.1from
beliefer:SPARK-37389-backport-3.1
Closed

[SPARK-37389][SQL][3.1] Check unclosed bracketed comments#34696
beliefer wants to merge 4 commits intoapache:branch-3.1from
beliefer:SPARK-37389-backport-3.1

Conversation

@beliefer
Copy link
Contributor

@beliefer beliefer commented Nov 24, 2021

What changes were proposed in this pull request?

This PR used to backport #34668 to branch 3.1

Why are the changes needed?

The execute plan is not expected, if we don't check unclosed bracketed comments.

Does this PR introduce any user-facing change?

'Yes'. The behavior of bracketed comments will more correctly.

How was this patch tested?

New tests.

@github-actions github-actions bot added the SQL label Nov 24, 2021
@SparkQA
Copy link

SparkQA commented Nov 24, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50046/

@SparkQA
Copy link

SparkQA commented Nov 24, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50046/

@SparkQA
Copy link

SparkQA commented Nov 24, 2021

Test build #145573 has finished for PR 34696 at commit 2bd8736.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • case class UnclosedCommentProcessor(

@SparkQA
Copy link

SparkQA commented Nov 24, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50054/

@SparkQA
Copy link

SparkQA commented Nov 24, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50054/

@SparkQA
Copy link

SparkQA commented Nov 24, 2021

Test build #145582 has finished for PR 34696 at commit a8e5167.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 25, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50071/

@SparkQA
Copy link

SparkQA commented Nov 25, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50071/

@SparkQA
Copy link

SparkQA commented Nov 25, 2021

Test build #145599 has finished for PR 34696 at commit 2618bee.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@beliefer
Copy link
Contributor Author

beliefer commented Nov 25, 2021

ping @cloud-fan

cloud-fan pushed a commit that referenced this pull request Nov 25, 2021
@beliefer @cloud-fan
[SPARK-37389][SQL][3.1] Check unclosed bracketed comments
61074aa 
### What changes were proposed in this pull request?
This PR used to backport #34668 to branch 3.1

### Why are the changes needed?
The execute plan is not expected, if we don't check unclosed bracketed comments.

### Does this PR introduce _any_ user-facing change?
'Yes'. The behavior of bracketed comments will more correctly.

### How was this patch tested?
New tests.

Closes #34696 from beliefer/SPARK-37389-backport-3.1.

Authored-by: Jiaan Geng <beliefer@163.com>
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
@cloud-fan
Copy link
Contributor

cloud-fan commented Nov 25, 2021

thanks, merging to 3.1!

@cloud-fan cloud-fan closed this Nov 25, 2021
@beliefer
Copy link
Contributor Author

beliefer commented Nov 25, 2021

@cloud-fan Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cloud-fan cloud-fan cloud-fan approved these changes

Assignees

No one assigned

Labels

SQL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@beliefer @SparkQA @cloud-fan

Comments