[SPARK-37459][BUILD] Upgrade commons-cli to 1.5.0#34707
Closed
sarutak wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-37459][BUILD] Upgrade commons-cli to 1.5.0#34707sarutak wants to merge 1 commit intoapache:masterfrom
sarutak wants to merge 1 commit intoapache:masterfrom
Conversation
HyukjinKwon
approved these changes
Nov 25, 2021
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
Member
|
Merged to master. |
|
Test build #145616 has finished for PR 34707 at commit
|
dongjoon-hyun
pushed a commit
that referenced
this pull request
Dec 4, 2023
### What changes were proposed in this pull request? The pr aims to upgrade `commons-cli` from `1.5.0` to `1.6.0`. ### Why are the changes needed? - The last upgrade occurred two years ago, #34707 - The full release notes: https://commons.apache.org/proper/commons-cli/changes-report.html#a1.6.0 - The version mainly focus on fixing bugs: Fix NPE in CommandLine.resolveOption(String). Fixes [CLI-283](https://issues.apache.org/jira/browse/CLI-283). CommandLine.addOption(Option) should not allow a null Option. Fixes [CLI-283](https://issues.apache.org/jira/browse/CLI-283). CommandLine.addArgs(String) should not allow a null String. Fixes [CLI-283](https://issues.apache.org/jira/browse/CLI-283). NullPointerException thrown by CommandLineParser.parse(). Fixes [CLI-317](https://issues.apache.org/jira/browse/CLI-317). StringIndexOutOfBoundsException thrown by CommandLineParser.parse(). Fixes [CLI-313](https://issues.apache.org/jira/browse/CLI-313). ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #44132 from panbingkun/SPARK-46218. Authored-by: panbingkun <pbk1982@gmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
asl3
pushed a commit
to asl3/spark
that referenced
this pull request
Dec 5, 2023
### What changes were proposed in this pull request? The pr aims to upgrade `commons-cli` from `1.5.0` to `1.6.0`. ### Why are the changes needed? - The last upgrade occurred two years ago, apache#34707 - The full release notes: https://commons.apache.org/proper/commons-cli/changes-report.html#a1.6.0 - The version mainly focus on fixing bugs: Fix NPE in CommandLine.resolveOption(String). Fixes [CLI-283](https://issues.apache.org/jira/browse/CLI-283). CommandLine.addOption(Option) should not allow a null Option. Fixes [CLI-283](https://issues.apache.org/jira/browse/CLI-283). CommandLine.addArgs(String) should not allow a null String. Fixes [CLI-283](https://issues.apache.org/jira/browse/CLI-283). NullPointerException thrown by CommandLineParser.parse(). Fixes [CLI-317](https://issues.apache.org/jira/browse/CLI-317). StringIndexOutOfBoundsException thrown by CommandLineParser.parse(). Fixes [CLI-313](https://issues.apache.org/jira/browse/CLI-313). ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#44132 from panbingkun/SPARK-46218. Authored-by: panbingkun <pbk1982@gmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
dbatomic
pushed a commit
to dbatomic/spark
that referenced
this pull request
Dec 11, 2023
### What changes were proposed in this pull request? The pr aims to upgrade `commons-cli` from `1.5.0` to `1.6.0`. ### Why are the changes needed? - The last upgrade occurred two years ago, apache#34707 - The full release notes: https://commons.apache.org/proper/commons-cli/changes-report.html#a1.6.0 - The version mainly focus on fixing bugs: Fix NPE in CommandLine.resolveOption(String). Fixes [CLI-283](https://issues.apache.org/jira/browse/CLI-283). CommandLine.addOption(Option) should not allow a null Option. Fixes [CLI-283](https://issues.apache.org/jira/browse/CLI-283). CommandLine.addArgs(String) should not allow a null String. Fixes [CLI-283](https://issues.apache.org/jira/browse/CLI-283). NullPointerException thrown by CommandLineParser.parse(). Fixes [CLI-317](https://issues.apache.org/jira/browse/CLI-317). StringIndexOutOfBoundsException thrown by CommandLineParser.parse(). Fixes [CLI-313](https://issues.apache.org/jira/browse/CLI-313). ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#44132 from panbingkun/SPARK-46218. Authored-by: panbingkun <pbk1982@gmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR upgrades
commons-clifrom1.2to1.5.0.Why are the changes needed?
Currently used commons-cli is too old and contains an issue which affects the behavior of bin/spark-sql
The root cause of this issue seems to be resolved in CLI-185.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Whether the build passes should be tested by CIs.
Confirmed
bin/spark-sql -e 'SELECT "Spark"'run successfully.