Skip to content

[SPARK-37548][INFRA][R][TESTS] Add Java17 SparkR daily test coverage#34808

Closed
dongjoon-hyun wants to merge 4 commits intoapache:masterfrom
dongjoon-hyun:SPARK-37548
Closed

[SPARK-37548][INFRA][R][TESTS] Add Java17 SparkR daily test coverage#34808
dongjoon-hyun wants to merge 4 commits intoapache:masterfrom
dongjoon-hyun:SPARK-37548

Conversation

@dongjoon-hyun
Copy link
Copy Markdown
Member

@dongjoon-hyun dongjoon-hyun commented Dec 5, 2021

What changes were proposed in this pull request?

This PR aims to add Java 17 SparkR daily test coverage.

Why are the changes needed?

To support Java 17 for SparkR in Apache Spark 3.3.0.

I manually tested SparkR UT on Java 17 on MacBook Pro (16-inch, 2021) Apple Silicon M1 Max.

$ java -version
openjdk version "17.0.1" 2021-10-19 LTS
OpenJDK Runtime Environment Zulu17.30+15-CA (build 17.0.1+12-LTS)
OpenJDK 64-Bit Server VM Zulu17.30+15-CA (build 17.0.1+12-LTS, mixed mode, sharing)

$ build/sbt -Phive -Psparkr test:package

$ R/install-dev.sh

$ env SPARK_HOME=$PWD R/run-tests.sh
...
══ Skipped ═════════════════════════════════════════════════════════════════════
1. sparkJars tag in SparkContext (test_Windows.R:22:5) - Reason: This test is only for Windows, skipped

══ DONE ════════════════════════════════════════════════════════════════════════
...
+ popd
Tests passed.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Manually review. This should be tested after merging.

@github-actions github-actions bot added the INFRA label Dec 5, 2021
@dongjoon-hyun
Copy link
Copy Markdown
Member Author

cc @HyukjinKwon and @LuciferYang

@SparkQA
Copy link
Copy Markdown

SparkQA commented Dec 5, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50400/

@dongjoon-hyun
Copy link
Copy Markdown
Member Author

Thank you, @HyukjinKwon ! Merged got master.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-37548 branch December 5, 2021 01:59
@SparkQA
Copy link
Copy Markdown

SparkQA commented Dec 5, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50400/

@SparkQA
Copy link
Copy Markdown

SparkQA commented Dec 5, 2021

Test build #145924 has finished for PR 34808 at commit e073a9d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@LuciferYang
Copy link
Copy Markdown
Contributor

LGTM +1

@dongjoon-hyun
Copy link
Copy Markdown
Member Author

dongjoon-hyun commented Dec 6, 2021

For a record, it passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants