[SPARK-37597][WIP] Deduplicate the right side of left-semi join and left-anti join#34850
Closed
zhengruifeng wants to merge 2 commits into
Closed
[SPARK-37597][WIP] Deduplicate the right side of left-semi join and left-anti join#34850zhengruifeng wants to merge 2 commits into
zhengruifeng wants to merge 2 commits into
Conversation
wangyum
reviewed
Dec 9, 2021
| RewriteCorrelatedScalarSubquery, | ||
| RewriteLateralSubquery, | ||
| EliminateSerialization, | ||
| DeduplicateLeftSemiLeftAntiRightSide, |
Member
There was a problem hiding this comment.
It should after RewriteSubquery to cover more cases.
Contributor
Author
|
test case: master: this pr: |
wangyum
reviewed
Dec 9, 2021
Comment on lines
+2158
to
+2159
| case join @ Join(_, right, LeftSemiOrAnti(_), _, _) if !right.isInstanceOf[Aggregate] => | ||
| join.copy(right = Aggregate(right.output, right.output, right)) |
Member
There was a problem hiding this comment.
Deduplicate is not always has benefit. This is my initial PR: b559901
Contributor
Author
There was a problem hiding this comment.
yes, there are some cases that had not been taken into account in this PR. I think b559901 is much better. I will close this one.
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #146038 has finished for PR 34850 at commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Deduplicate the right side of left-semi join and left-anti join
Why are the changes needed?
1, reduce the shuffle amount in the right side;
2, improve the chance to broadcast the right side;
3, reslove skewed keys in the right side;
Does this PR introduce any user-facing change?
No
How was this patch tested?
added testsuits