[SPARK-37688][CORE] ExecutorMonitor should ignore SparkListenerBlockUpdated event if executor was not active#34956
Closed
sleep1661 wants to merge 2 commits intoapache:masterfrom
sleep1661:SPARK-37688
Closed
[SPARK-37688][CORE] ExecutorMonitor should ignore SparkListenerBlockUpdated event if executor was not active#34956sleep1661 wants to merge 2 commits intoapache:masterfrom sleep1661:SPARK-37688
sleep1661 wants to merge 2 commits intoapache:masterfrom
sleep1661:SPARK-37688
Conversation
…event if executor was not active
|
Can one of the admins verify this patch? |
Contributor
Author
|
cc @mridulm |
Contributor
|
Looks fine to me. |
Contributor
Author
|
ping @Ngone51 |
Contributor
Author
|
@cloud-fan Could you help take a look when you have time? Thanks. |
Contributor
|
Merged to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ExecutorMonitorshould ignoreSparkListenerBlockUpdatedevent if executor was not activeWhy are the changes needed?
If not ignored,
ExecutorMonitorwill create a new executor tracker with UNKNOWN_RESOURCE_PROFILE_ID for the dead executor. AndExecutorAllocationManagerwill not remove executor with UNKNOWN_RESOURCE_PROFILE_ID, which cause a executor slot is occupied by the dead executor, so a new one cannot be created.Does this PR introduce any user-facing change?
No
How was this patch tested?
Add a new test.