Skip to content

[MINOR][UI] Fix Duration tips of Stage Table on UI#34967

Closed
yaooqinn wants to merge 1 commit intoapache:masterfrom
yaooqinn:tips
Closed

[MINOR][UI] Fix Duration tips of Stage Table on UI#34967
yaooqinn wants to merge 1 commit intoapache:masterfrom
yaooqinn:tips

Conversation

@yaooqinn
Copy link
Member

What changes were proposed in this pull request?

After c07a50b the duration of a stage on UI does not display as stage completion time - submission time, the completion time - 1st task launch time.

In this PR, we fix the tips to prevent misleading.

Why are the changes needed?

the description of Stage Duration confuses me for a long time as it is not consistent with the job duration if the job has one stage only.

Does this PR introduce any user-facing change?

yes, UI changes.

How was this patch tested?

Passing GA

@SparkQA
Copy link

SparkQA commented Dec 21, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50900/

@SparkQA
Copy link

SparkQA commented Dec 21, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50900/

@SparkQA
Copy link

SparkQA commented Dec 21, 2021

Test build #146426 has finished for PR 34967 at commit 63bce7f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yaooqinn
Copy link
Member Author

cc @cloud-fan @Ngone51

@cloud-fan
Copy link
Contributor

looks reasonable. @Ngone51 can you signoff this?

Copy link
Member

@Ngone51 Ngone51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ngone51 Ngone51 closed this in 7d88f1c Dec 22, 2021
@Ngone51
Copy link
Member

Ngone51 commented Dec 22, 2021

Thanks, merged to master!

@yaooqinn yaooqinn deleted the tips branch December 22, 2021 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments