[SPARK-37429][PYTHON][MLLIB] Inline annotations for pyspark.mllib.linalg.__init__.py #35020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zero323
commented
Dec 27, 2021
Member
Author
There was a problem hiding this comment.
This is intentionally simplified compared to pyi implementation ‒ there seems to be no advantage of keeping original overloads.
zero323
commented
Dec 27, 2021
Comment on lines
+1484
to
+1486
Member
Author
There was a problem hiding this comment.
For some reason, mypy doesn't recognize ndarray.tostring.
zero323
changed the title
Member
|
cc @WeichenXu123 . If there are no reviews being done, I would be fine to go ahead as are. I will leave it to you @zero323 - I have less background on ML side .. |
HyukjinKwon
approved these changes
Jan 7, 2022
HyukjinKwon
reviewed
Jan 14, 2022
HyukjinKwon
reviewed
Jan 14, 2022
Member
Author
|
Merged into master. |
dchvn
pushed a commit
to dchvn/spark
that referenced
this pull request
Jan 19, 2022
…alg.__init__.py ### What changes were proposed in this pull request? Inline annotations for `pyspark.mllib.linalg.__init__.py` ### Why are the changes needed? Currently, there is type hint stub files `pyspark.mllib.linalg.__init__.pyi` to show the expected types for functions, but we can also take advantage of static type checking within the functions by inlining the type hints. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests. Closes apache#35020 from zero323/SPARK-37429. Authored-by: zero323 <mszymkiewicz@gmail.com> Signed-off-by: zero323 <mszymkiewicz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Inline annotations for
pyspark.mllib.linalg.__init__.pyWhy are the changes needed?
Currently, there is type hint stub files
pyspark.mllib.linalg.__init__.pyito show the expected types for functions, but we can also take advantage of static type checking within the functions by inlining the type hints.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.