Skip to content

Comments

[SPARK-33565][PYTHON][BUILD] Configure Python3.9 in python run-tests.py#35087

Closed
Yikun wants to merge 1 commit intoapache:masterfrom
Yikun:SPARK-33565
Closed

[SPARK-33565][PYTHON][BUILD] Configure Python3.9 in python run-tests.py#35087
Yikun wants to merge 1 commit intoapache:masterfrom
Yikun:SPARK-33565

Conversation

@Yikun
Copy link
Member

@Yikun Yikun commented Jan 3, 2022

What changes were proposed in this pull request?

  • Remove temporary workaround in run-tests
  • Move the workaround to python/run-tests.py

Why are the changes needed?

As the note mentioned:

Python 3.9 was temporarily removed as its default Python executables to test because of Jenkins environment issue. Once Jenkins has Python 3.9 to test, we should remove this change back and add python3.9 into python/run-tests.py script.

This cleanup will also help to user only run python/run-tests.py with python3.9 and also pypy3 as default.

Does this PR introduce any user-facing change?

It marks python3.9 and pypy3 as default test runner python executors.

How was this patch tested?

CI passed, and PySpark test are still running under python3.9 and pypy3.

@Yikun
Copy link
Member Author

Yikun commented Jan 3, 2022

Will test against the following Python executables: ['python3.9', 'pypy3']

it works in pyspark test.

@Yikun Yikun marked this pull request as ready for review January 3, 2022 07:45
Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Yikun. LGTM

@HyukjinKwon
Copy link
Member

Merged to master.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants