[SPARK-36543][CORE] Rearranged logging in decommission loop#35094
[SPARK-36543][CORE] Rearranged logging in decommission loop#35094sungpeo wants to merge 1 commit intoapache:masterfrom
Conversation
|
@holdenk |
|
@sungpeo BTW, Apache Spark repository leverages the resources from GItHub Actions in your forked repository for your PR so it should be enabled in your forked repository to run the tests, see also https://github.com/apache/spark/pull/35094/checks?check_run_id=4699635992. |
|
Can one of the admins verify this patch? |
|
@HyukjinKwon I enabled Github actions again, and sync (rebase) my branch to the latest master. |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Sorry, but I'm -1 for this change. This is helpful to detect the decommissioners' misbehavior or some deadlock situation. Why do you need to suppress this, @sungpeo ?
|
@dongjoon-hyun Below logInfo(s) were repeated every loop for waiting done. ...
logInfo("Checking to see if we can shutdown.")
...
logInfo("No running tasks, checking migrations")
...
logInfo("All blocks not yet migrated.") |
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
What changes were proposed in this pull request?
Lower logging level, and transferred logInfo in a loop to outside
Why are the changes needed?
[SPARK-36543] Decommission logs too frequent when waiting migration to finish
Does this PR introduce any user-facing change?
Yes, it changes the level of logs, and make it less frequent.
How was this patch tested?
It doesn't need