Skip to content

[SPARK-4651] Adding -Phadoop-2.4+ to compile Spark with newer versions of Hadoop#3512

Closed
oza wants to merge 1 commit intoapache:masterfrom
oza:SPARK-4651
Closed

[SPARK-4651] Adding -Phadoop-2.4+ to compile Spark with newer versions of Hadoop#3512
oza wants to merge 1 commit intoapache:masterfrom
oza:SPARK-4651

Conversation

@oza
Copy link
Contributor

@oza oza commented Nov 29, 2014

No description provided.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@srowen
Copy link
Member

srowen commented Nov 29, 2014

This PR is messed up and needs to be rebased, at least, but see JIRA comments.

@oza
Copy link
Contributor Author

oza commented Nov 29, 2014

@srowen Oh, my bad. I'm rebasing the patch.

@oza
Copy link
Contributor Author

oza commented Nov 29, 2014

@srowen Updated. I ran Spark on YARN with Hadoop 2.5.2 by compiling this option.

@oza oza changed the title [SPARK-4651] Adding -Phadoop-2.5 and -Phadoop-2.6 to compile Spark with newer versions of Hadoop [SPARK-4651] Adding -Phadoop-2.4+ to compile Spark with newer versions of Hadoop Nov 29, 2014
Signed-off-by: Tsuyoshi Ozawa <ozawa.tsuyoshi@gmail.com>
@pwendell
Copy link
Contributor

Hi there - this doesn't make sense because what if they release 2.6, 2.7, etc and it doesn't work with this profile?

@sryza
Copy link
Contributor

sryza commented Nov 30, 2014

This has come up before, and I thought we resolved that the hadoop-2.4 profile would be used for all Hadoop versions above 2.5, until a Hadoop version changes dependencies in such a way that we must add a new profile.

@pwendell
Copy link
Contributor

Yes, I think that is what our docs say. So then this new profile isn't necessary

@oza
Copy link
Contributor Author

oza commented Nov 30, 2014

Then, can I update the version of Hadoop used in -Phadoop-2.4 to 2.5.2 instead of adding new profile? It's latest stable version.

@pwendell
Copy link
Contributor

In the docs we offically recommend "mvn -Pyarn -Phadoop-2.4 -Dhadoop.version=VERSION -DskipTests clean package" for Hadoop 2.4.X and 2.5.X. I'd prefer this to modifying the name of this profile. It's just one more build flag.

@oza
Copy link
Contributor Author

oza commented Nov 30, 2014

Make sense. Closing this ticket. Thanks for your comments, Patrick, Sandy, and Sean!

@oza oza closed this Nov 30, 2014
@pwendell
Copy link
Contributor

pwendell commented Dec 1, 2014

No problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants