[SPARK-37853][CORE] Clean up deprecation compilation warning related to log4j2 by LuciferYang · Pull Request #35153 · apache/spark

LuciferYang · 2022-01-10T09:14:04Z

What changes were proposed in this pull request?

The are 2 deprecation compilation warning related to log4j2:

[WARNING] [Warn] /spark-source/core/src/main/scala/org/apache/spark/util/logging/DriverLogger.scala:64: [deprecation @ org.apache.spark.util.logging.DriverLogger.addLogAppender.fa | origin=org.apache.logging.log4j.core.appender.FileAppender.createAppender | version=] method createAppender in class FileAppender is deprecated
[WARNING] [Warn] /spark-source/core/src/test/scala/org/apache/spark/SparkFunSuite.scala:268: [deprecation @ org.apache.spark.SparkFunSuite.LogAppender.<init> | origin=org.apache.logging.log4j.core.appender.AbstractAppender.<init> | version=] constructor AbstractAppender in class AbstractAppender is deprecated

In order to fix the above compilation warning, the main change of this pr as follows:

Log4jFileAppender.Builder is used instead of Log4jFileAppender.createAppender to fix compilation warning of DriverLogger, and the configuration of some default values is omitted refer to SPARK-6305.

The initial status of Log4jFileAppender.Builder as follows:

fileName = null
append = true
locking = false
advertise = false
advertiseUri = null
createOnDemand = false
filePermissions = null
fileOwner = null
fileGroup = null
bufferedIo = true
bufferSize = 8192
immediateFlush = true
ignoreExceptions = true
layout = null
name = null
configuration = null
filter = null
propertyArray = null

And we can't use the chained API invocation mode because AbstractFilterable.Builder.asBuilder() method will return Any in Scala.

Use the recommended constructor of AbstractAppender refer to javadoc to fix compilation warning in SparkFunSuite.

Why are the changes needed?

Clean up deprecation compilation warning related to log4j2

Does this PR introduce any user-facing change?

No

How was this patch tested?

Pass GA

dongjoon-hyun · 2022-01-10T23:08:38Z

cc @viirya

dongjoon-hyun · 2022-01-10T23:18:33Z

-    val fa = Log4jFileAppender.createAppender(localLogFile, "false", "false",
-      DriverLogger.APPENDER_NAME, "true", "false", "false", "4000", layout, null,
-      "false", null, config);
+    def log4jFileAppender() = {


This is not a [TESTS], @LuciferYang .

Thanks for your correction

dongjoon-hyun

+1, LGTM. Merged to master for Apache Spark 3.3.

…to log4j2 ### What changes were proposed in this pull request? The are 2 deprecation compilation warning related to log4j2: ``` [WARNING] [Warn] /spark-source/core/src/main/scala/org/apache/spark/util/logging/DriverLogger.scala:64: [deprecation org.apache.spark.util.logging.DriverLogger.addLogAppender.fa | origin=org.apache.logging.log4j.core.appender.FileAppender.createAppender | version=] method createAppender in class FileAppender is deprecated [WARNING] [Warn] /spark-source/core/src/test/scala/org/apache/spark/SparkFunSuite.scala:268: [deprecation org.apache.spark.SparkFunSuite.LogAppender.<init> | origin=org.apache.logging.log4j.core.appender.AbstractAppender.<init> | version=] constructor AbstractAppender in class AbstractAppender is deprecated ``` In order to fix the above compilation warning, the main change of this pr as follows: 1. `Log4jFileAppender.Builder` is used instead of `Log4jFileAppender.createAppender` to fix compilation warning of `DriverLogger`, and the configuration of some default values is omitted refer to SPARK-6305. The initial status of `Log4jFileAppender.Builder` as follows: ```java fileName = null append = true locking = false advertise = false advertiseUri = null createOnDemand = false filePermissions = null fileOwner = null fileGroup = null bufferedIo = true bufferSize = 8192 immediateFlush = true ignoreExceptions = true layout = null name = null configuration = null filter = null propertyArray = null ``` And we can't use the chained API invocation mode because `AbstractFilterable.Builder.asBuilder()` method will return `Any` in Scala. 2. Use the recommended constructor of `AbstractAppender` refer to javadoc to fix compilation warning in `SparkFunSuite`. ### Why are the changes needed? Clean up deprecation compilation warning related to log4j2 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GA Closes apache#35153 from LuciferYang/SPARK-37853. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>

…to log4j2 The are 2 deprecation compilation warning related to log4j2: ``` [WARNING] [Warn] /spark-source/core/src/main/scala/org/apache/spark/util/logging/DriverLogger.scala:64: [deprecation org.apache.spark.util.logging.DriverLogger.addLogAppender.fa | origin=org.apache.logging.log4j.core.appender.FileAppender.createAppender | version=] method createAppender in class FileAppender is deprecated [WARNING] [Warn] /spark-source/core/src/test/scala/org/apache/spark/SparkFunSuite.scala:268: [deprecation org.apache.spark.SparkFunSuite.LogAppender.<init> | origin=org.apache.logging.log4j.core.appender.AbstractAppender.<init> | version=] constructor AbstractAppender in class AbstractAppender is deprecated ``` In order to fix the above compilation warning, the main change of this pr as follows: 1. `Log4jFileAppender.Builder` is used instead of `Log4jFileAppender.createAppender` to fix compilation warning of `DriverLogger`, and the configuration of some default values is omitted refer to SPARK-6305. The initial status of `Log4jFileAppender.Builder` as follows: ```java fileName = null append = true locking = false advertise = false advertiseUri = null createOnDemand = false filePermissions = null fileOwner = null fileGroup = null bufferedIo = true bufferSize = 8192 immediateFlush = true ignoreExceptions = true layout = null name = null configuration = null filter = null propertyArray = null ``` And we can't use the chained API invocation mode because `AbstractFilterable.Builder.asBuilder()` method will return `Any` in Scala. 2. Use the recommended constructor of `AbstractAppender` refer to javadoc to fix compilation warning in `SparkFunSuite`. Clean up deprecation compilation warning related to log4j2 No Pass GA Closes apache#35153 from LuciferYang/SPARK-37853. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>

…to log4j2 ### What changes were proposed in this pull request? The are 2 deprecation compilation warning related to log4j2: ``` [WARNING] [Warn] /spark-source/core/src/main/scala/org/apache/spark/util/logging/DriverLogger.scala:64: [deprecation org.apache.spark.util.logging.DriverLogger.addLogAppender.fa | origin=org.apache.logging.log4j.core.appender.FileAppender.createAppender | version=] method createAppender in class FileAppender is deprecated [WARNING] [Warn] /spark-source/core/src/test/scala/org/apache/spark/SparkFunSuite.scala:268: [deprecation org.apache.spark.SparkFunSuite.LogAppender.<init> | origin=org.apache.logging.log4j.core.appender.AbstractAppender.<init> | version=] constructor AbstractAppender in class AbstractAppender is deprecated ``` In order to fix the above compilation warning, the main change of this pr as follows: 1. `Log4jFileAppender.Builder` is used instead of `Log4jFileAppender.createAppender` to fix compilation warning of `DriverLogger`, and the configuration of some default values is omitted refer to SPARK-6305. The initial status of `Log4jFileAppender.Builder` as follows: ```java fileName = null append = true locking = false advertise = false advertiseUri = null createOnDemand = false filePermissions = null fileOwner = null fileGroup = null bufferedIo = true bufferSize = 8192 immediateFlush = true ignoreExceptions = true layout = null name = null configuration = null filter = null propertyArray = null ``` And we can't use the chained API invocation mode because `AbstractFilterable.Builder.asBuilder()` method will return `Any` in Scala. 2. Use the recommended constructor of `AbstractAppender` refer to javadoc to fix compilation warning in `SparkFunSuite`. ### Why are the changes needed? Clean up deprecation compilation warning related to log4j2 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GA Closes apache#35153 from LuciferYang/SPARK-37853. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 9c12c37)

LuciferYang added 2 commits January 10, 2022 16:45

fix compilation warning

8eeae41

add comments

1c85629

github-actions Bot added the CORE label Jan 10, 2022

LuciferYang changed the title ~~[SPARK-37853][CORE][TEST] Clean up deprecation compilation warning related to log4j2~~ [SPARK-37853][CORE][TESTS] Clean up deprecation compilation warning related to log4j2 Jan 10, 2022

remove unnecessary change

df0de64

github-actions Bot added AVRO SQL labels Jan 10, 2022

LuciferYang added 2 commits January 10, 2022 17:21

remove unnecessary change

cb744a9

reorder import

2043bf6

gengliangwang approved these changes Jan 10, 2022

View reviewed changes

srowen approved these changes Jan 10, 2022

View reviewed changes

viirya approved these changes Jan 10, 2022

View reviewed changes

dongjoon-hyun reviewed Jan 10, 2022

View reviewed changes

dongjoon-hyun changed the title ~~[SPARK-37853][CORE][TESTS] Clean up deprecation compilation warning related to log4j2~~ [SPARK-37853][CORE] Clean up deprecation compilation warning related to log4j2 Jan 10, 2022

dongjoon-hyun approved these changes Jan 10, 2022

View reviewed changes

dongjoon-hyun closed this in 9c12c37 Jan 10, 2022

LuciferYang deleted the SPARK-37853 branch October 22, 2023 07:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SPARK-37853][CORE] Clean up deprecation compilation warning related to log4j2#35153

[SPARK-37853][CORE] Clean up deprecation compilation warning related to log4j2#35153
LuciferYang wants to merge 5 commits intoapache:masterfrom
LuciferYang:SPARK-37853

LuciferYang commented Jan 10, 2022 •

edited

Loading

Uh oh!

dongjoon-hyun commented Jan 10, 2022

Uh oh!

dongjoon-hyun Jan 10, 2022

Uh oh!

LuciferYang Jan 11, 2022

Uh oh!

dongjoon-hyun left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

LuciferYang commented Jan 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Uh oh!

dongjoon-hyun commented Jan 10, 2022

Uh oh!

dongjoon-hyun Jan 10, 2022

Choose a reason for hiding this comment

Uh oh!

LuciferYang Jan 11, 2022

Choose a reason for hiding this comment

Uh oh!

dongjoon-hyun left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

LuciferYang commented Jan 10, 2022 •

edited

Loading