[SPARK-37862][SQL] RecordBinaryComparator should fast skip the check of aligning with unaligned platform#35161
Closed
ulysses-you wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-37862][SQL] RecordBinaryComparator should fast skip the check of aligning with unaligned platform#35161ulysses-you wants to merge 1 commit intoapache:masterfrom
ulysses-you wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
cc @srowen |
Member
|
Are there other instances like this? |
Contributor
Author
That's all. I searched and this PR is the only place should be changed
the related code are totally same, so cannot find the reason to re-produce the bencharmk result.. |
Member
|
I tend to agree this change is good simply for consistency. I'm wondering if it is possible this is not a win as applied in this code path, but unlikely |
Member
|
Merged to master |
Contributor
Author
|
thank you @srowen |
dchvn
pushed a commit
to dchvn/spark
that referenced
this pull request
Jan 19, 2022
…of aligning with unaligned platform ### What changes were proposed in this pull request? `RecordBinaryComparator` compare the entire row, so it need to check if the platform is unaligned. apache#35078 had given the perf number to show the benefits. So this PR aims to do the same thing that fast skip the check of aligning with unaligned platform. ### Why are the changes needed? Improve the performance. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? Pass CI. And the perf number should be same with apache#35078 Closes apache#35161 from ulysses-you/unaligned. Authored-by: ulysses-you <ulyssesyou18@gmail.com> Signed-off-by: Sean Owen <srowen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
RecordBinaryComparatorcompare the entire row, so it need to check if the platform is unaligned. #35078 had given the perf number to show the benefits. So this PR aims to do the same thing that fast skip the check of aligning with unaligned platform.Why are the changes needed?
Improve the performance.
Does this PR introduce any user-facing change?
no
How was this patch tested?
Pass CI. And the perf number should be same with #35078