[SPARK-37899][SQL] EliminateInnerJoin to support convert inner join to left semi join#35194
Closed
wangyum wants to merge 2 commits intoapache:masterfrom
wangyum:SPARK-37899
Closed
[SPARK-37899][SQL] EliminateInnerJoin to support convert inner join to left semi join#35194wangyum wants to merge 2 commits intoapache:masterfrom wangyum:SPARK-37899
wangyum wants to merge 2 commits intoapache:masterfrom
wangyum:SPARK-37899
Conversation
Contributor
|
Just curious why |
| def apply(plan: LogicalPlan): LogicalPlan = { | ||
| plan.transformWithPruning(_.containsPattern(INNER_LIKE_JOIN), ruleId) { | ||
| case p @ Project(_, | ||
| j @ ExtractEquiJoinKeys(Inner, _, rightKeys, None, _, left, right: Aggregate, _)) |
Contributor
There was a problem hiding this comment.
Inner join is symmetrical, can this rule also be applied to inner join with left Aggregate child?
j @ ExtractEquiJoinKeys(Inner, leftKeys, _, _, None, left: Aggregate, _, _))
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add a new rule(
EliminateInnerJoin) to support convert inner join to left semi join. It has two advantages:BroadcastHashJoins can be planned.PushDownLeftSemiAntiJoinandPushLeftSemiLeftAntiThroughJoin) to optimize left semi join.This is a real case:
Before this pr:
After this pr:
Why are the changes needed?
Improve query performance.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit test and TPC-DS benchmark test.