[SPARK-37415][PYTHON][ML] Inline type hints for pyspark.ml.util#35367
Closed
zero323 wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-37415][PYTHON][ML] Inline type hints for pyspark.ml.util#35367zero323 wants to merge 3 commits intoapache:masterfrom
zero323 wants to merge 3 commits intoapache:masterfrom
Conversation
Member
Author
|
This is just a rough draft ‒ I'll revisit it once SPARK-37397 (and revise it to address any possible issues detected during parallel work on SPARK-37416). |
HyukjinKwon
approved these changes
Feb 3, 2022
Member
Author
|
Thanks for the review @HyukjinKwon! I am still working on this one (there was an issue with some of the |
zero323
changed the title
Member
Author
|
Run the test run with #35399 and both seem to work well together. |
HyukjinKwon
approved these changes
Feb 6, 2022
Member
Author
|
Merged into master. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR migrates type
pyspark.ml.utilannotations from stub file to inline type hints.Why are the changes needed?
Part of ongoing migration of type hints.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.