Skip to content

[SPARK-37406][PYTHON][ML] Inline hints for pyspark.ml.fpm#35407

Closed
zero323 wants to merge 1 commit intoapache:masterfrom
zero323:SPARK-37406
Closed

[SPARK-37406][PYTHON][ML] Inline hints for pyspark.ml.fpm#35407
zero323 wants to merge 1 commit intoapache:masterfrom
zero323:SPARK-37406

Conversation

@zero323
Copy link
Member

@zero323 zero323 commented Feb 6, 2022

What changes were proposed in this pull request?

This PR migrates type pyspark.ml.fpm annotations from stub file to inline type hints.

Why are the changes needed?

Part of ongoing migration of type hints.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing tests.

@zero323
Copy link
Member Author

zero323 commented Feb 6, 2022

This depends on JavaEstimator being runtime generic (SPARK-37416 / #35399) and I'll sync these once the other one is merged, but I already tested integration locally.

@zero323 zero323 changed the title [WIP][SPARK-37406][PYTHON][ML] Inline hints for pyspark.ml.fpm [SPARK-37406][PYTHON][ML] Inline hints for pyspark.ml.fpm Feb 7, 2022
@zero323 zero323 marked this pull request as ready for review February 7, 2022 00:44
@zero323
Copy link
Member Author

zero323 commented Feb 10, 2022

Merged into master.

@zero323 zero323 deleted the SPARK-37406 branch February 10, 2022 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants