[SPARK-33274][SS] Stop query in cp mode when total cores less than total kafka partition#35500
Closed
warrenzhu25 wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-33274][SS] Stop query in cp mode when total cores less than total kafka partition#35500warrenzhu25 wants to merge 1 commit intoapache:masterfrom
warrenzhu25 wants to merge 1 commit intoapache:masterfrom
Conversation
|
Can one of the admins verify this patch? |
…total kafka partition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add check for total executor cores when
SetReaderPartitionsmessage received.Why are the changes needed?
In continuous processing mode, EpochCoordinator won't add offsets to query until got ReportPartitionOffset from all partitions. Normally, each kafka topic partition will be handled by one core, if total cores is smaller than total kafka topic partition counts, the job will hang without any error message.
Does this PR introduce any user-facing change?
Yes, if total executor cores is smaller than total kafka partition count, the exception with below error will be thrown:
Total %s (kafka partitions) * %s (cpus per task) = %s needed, but only have %s (executors) * %s (cores per executor) = %s (total cores). Please increase total number of executor cores to at least %s.How was this patch tested?
Added test in EpochCoordinatorSuite