[SPARK-38229][SQL] Should't check temp/external/ifNotExists with visitReplaceTable when parser#35541
Closed
yikf wants to merge 2 commits intoapache:masterfrom
yikf:SPARK-38229
Closed
[SPARK-38229][SQL] Should't check temp/external/ifNotExists with visitReplaceTable when parser#35541yikf wants to merge 2 commits intoapache:masterfrom yikf:SPARK-38229
yikf wants to merge 2 commits intoapache:masterfrom
yikf:SPARK-38229
Conversation
Contributor
Author
|
@cloud-fan Could you please take a look, thanks |
|
Can one of the admins verify this patch? |
cloud-fan
approved these changes
Feb 17, 2022
Contributor
|
thanks, merging to master! |
cloud-fan
reviewed
Feb 23, 2022
| */ | ||
| override def visitReplaceTableHeader( | ||
| ctx: ReplaceTableHeaderContext): TableHeader = withOrigin(ctx) { | ||
| ctx: ReplaceTableHeaderContext): Seq[String] = withOrigin(ctx) { |
Contributor
There was a problem hiding this comment.
Can we further clean it up? Now this method simply parses the table name, and we don't need to have a visitReplaceTableHeader method for it.
Contributor
Author
There was a problem hiding this comment.
Sure, I will file a follow-up for it later
This was referenced Feb 23, 2022
cloud-fan
pushed a commit
that referenced
this pull request
Feb 24, 2022
…ification ### What changes were proposed in this pull request? Clean up unnecessary code for code simplification, see [comment](#35541 (comment)) ### Why are the changes needed? code simplification ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Exist ut Closes #35642 from Yikf/r. Authored-by: Yikf <yikaifei1@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Spark does not support replace table syntax such as CREATE OR REPLACE TEMPORARY TABLE.../REPLACE EXTERNAL TABLE/REPLACE ... IF NOT EXISTS, And we don't need to check these tokens
Why are the changes needed?
code simplification
Does this PR introduce any user-facing change?
No
How was this patch tested?
Exist ut