[SPARK-38392][K8S][TESTS] Add spark- prefix to namespaces and -driver suffix to drivers during IT#35711
Closed
martin-g wants to merge 1 commit intoapache:masterfrom
martin-g:k8s-test-names-improvement
Closed
[SPARK-38392][K8S][TESTS] Add spark- prefix to namespaces and -driver suffix to drivers during IT#35711martin-g wants to merge 1 commit intoapache:masterfrom martin-g:k8s-test-names-improvement
spark- prefix to namespaces and -driver suffix to drivers during IT#35711martin-g wants to merge 1 commit intoapache:masterfrom
martin-g:k8s-test-names-improvement
Conversation
…r pod in integration tests Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Hi, @martin-g . Apache Spark community uses [TESTS] in the PR title for test-only PRs.
dongjoon-hyun
changed the title
spark- prefix to namespaces and -driver suffix to drivers during IT
dongjoon-hyun
approved these changes
Mar 2, 2022
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. I agree with you for both proposals.
(I'm testing K8s IT now).
Member
|
It's verified. Merged to master/3.2. |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Mar 2, 2022
…ver` suffix to drivers during IT ### What changes were proposed in this pull request? There are two small proposals: 1) prefix the name of the temporary k8s namespaces with `"spark-"` so that the output of `kubectl get ns" is more clear. 2) unify the name of the driver pod in non-test and IT tests to always use `-driver` as a suffix. ### Why are the changes needed? At the moment the name of the temporary namespace is just UUID without the `-`s. When one reads the result of `kubectl get ns` it is a bit cryptic to see UUIDs. The names of the driver pods in ITs are not telling me that they are Drivers. In non-test (i.e. production) the driver pod names are suffixed with `-driver`. I propose the same for IT tests. Executor pods always use `-exec-` in their pod names, both in non-test and ITs. ### Does this PR introduce _any_ user-facing change? Yes! Developers who debug IT tests will see more clear names now. ### How was this patch tested? Manually with `kubectl get ns --watch` and `kubectl get po --watch`. Closes #35711 from martin-g/k8s-test-names-improvement. Authored-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 4d4c044) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
|
FYI, for test-only PRs, we can backport it into old release branches if needed. |
kazuyukitanimura
pushed a commit
to kazuyukitanimura/spark
that referenced
this pull request
Aug 10, 2022
…ver` suffix to drivers during IT ### What changes were proposed in this pull request? There are two small proposals: 1) prefix the name of the temporary k8s namespaces with `"spark-"` so that the output of `kubectl get ns" is more clear. 2) unify the name of the driver pod in non-test and IT tests to always use `-driver` as a suffix. ### Why are the changes needed? At the moment the name of the temporary namespace is just UUID without the `-`s. When one reads the result of `kubectl get ns` it is a bit cryptic to see UUIDs. The names of the driver pods in ITs are not telling me that they are Drivers. In non-test (i.e. production) the driver pod names are suffixed with `-driver`. I propose the same for IT tests. Executor pods always use `-exec-` in their pod names, both in non-test and ITs. ### Does this PR introduce _any_ user-facing change? Yes! Developers who debug IT tests will see more clear names now. ### How was this patch tested? Manually with `kubectl get ns --watch` and `kubectl get po --watch`. Closes apache#35711 from martin-g/k8s-test-names-improvement. Authored-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 4d4c044) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit ff1794f) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
There are two small proposals:
"spark-"so that the output of `kubectl get ns" is more clear.-driveras a suffix.Why are the changes needed?
At the moment the name of the temporary namespace is just UUID without the
-s. When one reads the result ofkubectl get nsit is a bit cryptic to see UUIDs.The names of the driver pods in ITs are not telling me that they are Drivers.
In non-test (i.e. production) the driver pod names are suffixed with
-driver. I propose the same for IT tests.Executor pods always use
-exec-in their pod names, both in non-test and ITs.Does this PR introduce any user-facing change?
Yes! Developers who debug IT tests will see more clear names now.
How was this patch tested?
Manually with
kubectl get ns --watchandkubectl get po --watch.