Skip to content

Comments

[SPARK-38405][SQL] Supports customization of the entire optimizer and planner#35721

Closed
chenjunbiao001 wants to merge 1 commit intoapache:masterfrom
chenjunbiao001:optimizer
Closed

[SPARK-38405][SQL] Supports customization of the entire optimizer and planner#35721
chenjunbiao001 wants to merge 1 commit intoapache:masterfrom
chenjunbiao001:optimizer

Conversation

@chenjunbiao001
Copy link

@github-actions github-actions bot added the SQL label Mar 3, 2022
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

val catalogManagerTypeName = Class.forName("org.apache.spark.sql.connector.catalog.CatalogManager")
val sessionCatalogTypeName = Class.forName("org.apache.spark.sql.catalyst.catalog.SessionCatalog")
val experimentalMethodsTypeName = Class.forName("org.apache.spark.sql.ExperimentalMethods")
val optimizerInstance = Class.forName(optimizerClassName).getConstructor(catalogManagerTypeName, sessionCatalogTypeName, experimentalMethodsTypeName).newInstance(catalogManager, catalog, experimentalMethods)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file line length exceeds 100 characters on line 247,248,250 and 304

https://github.com/databricks/scala-style-guide#linelength

Copy link
Member

@wangyum wangyum Mar 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chenjunbiao001 @nyingping Could we use spark.sql.extensions to add custom optimizer rules?

override def preCBORules: Seq[Rule[LogicalPlan]] =
super.preCBORules ++ customPreCBORules
override def preCBORules: Seq[Rule[LogicalPlan]] =
super.preCBORules ++ customPreCBORules
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit. redundant space on line 257,258.

@nyingping
Copy link
Contributor

nyingping commented Mar 4, 2022

It might be clearer if the PR title could be changed to : [SPARK-38405][SQL] Supports customization of the entire optimizer and planner

PR description may be in the default format to make the community better understand your intention.

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Please open GA in your fork repository

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository

@chenjunbiao001 chenjunbiao001 changed the title Supports customization of the entire optimizer and planner [SPARK-38405][SQL] Supports customization of the entire optimizer and planner Mar 7, 2022
@github-actions
Copy link

We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!

@github-actions github-actions bot added the Stale label Jun 21, 2022
@chenjunbiao001
Copy link
Author

chenjunbiao001 commented Jun 21, 2022 via email

@github-actions github-actions bot closed this Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants