[MINOR][DOCS] Fix minor typos at nulls_option in Window Functions#35774
[MINOR][DOCS] Fix minor typos at nulls_option in Window Functions#35774bfallik wants to merge 2 commits intoapache:masterfrom
Conversation
I'm just learning Spark but am assuming that these code examples refer to the `RESPECT NULLS` syntax called out just below.
|
Could you make the test pass by allowing Github Actions in your forked repository ?? Please refer to https://github.com/apache/spark/pull/35774/checks?check_run_id=5467958735. |
|
And for "Does this PR introduce any user-facing change?", I think we have user-facing change since we fix the typo in the documentation which users can read. So, maybe we can simply say like, "Yes, the typo in documentation is corrected" or something. |
|
@itholic after enabling github actions on my private repo, how do I rerun the failed check? I don't see any obvious way to do it within the GH UI. |
|
Here is an example:
Or, you can just push the empty commit to rerun the test via |
|
Can one of the admins verify this patch? |
|
@itholic looks like the tests all pass now |
|
Great! BTW, also we should follow the contribution guideline from community. Can you create a related Apache Spark JIRA and fix the title ?? And I think maybe we would move the description "I'm just learning Spark but am assuming that these code examples refer to the RESPECT NULLS syntax called out just below." to under "Why are the changes needed?" or just remove. You can also refer to other PRs as reference :-) |
|
Hi @itholic , Please know that I appreciate all the hard work, often thankless, that project committers undertake to try and manage community activity into a sensible workflow, but this is starting to feel like a lot of back-and-forth for a documentation change to correct an obvious misspelling. I did review the contribution guidelines before posting this PR. The section on "Contributing documentation changes" says
and, notably, the section on "Contributing code changes" says
I read that example and assumed this trivial change didn't need a JIRA ticket. I'll go ahead and edit the description to address your most recent suggestion. Appreciate your help getting the automated checks to pass. Thanks. |
|
@bfallik That makes sense to me. Thanks for the update description! |
|
cc @HyukjinKwon I think maybe we could just merge this trivial patch? |
|
Merged to master. |



What changes were proposed in this pull request?
Fix a typo:
RESECT->RESPECT.Why are the changes needed?
RESECTisn't a valid term hereDoes this PR introduce any user-facing change?
Yes, the typos in the docs are corrected.
How was this patch tested?
inspection via the Github UI