Closed
Conversation
Member
Author
HyukjinKwon
approved these changes
Mar 23, 2022
Member
|
Merged to master and branch-3.3. cc @HeartSaVioR too FYI |
HyukjinKwon
pushed a commit
that referenced
this pull request
Mar 23, 2022
### What changes were proposed in this pull request? Add missing `since` for DSv2 API ### Why are the changes needed? Let users know which version of the API was introduced. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? The change does not touch the code. Closes #35935 from pan3793/minor. Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit f73d528) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Contributor
|
Nice catch! |
|
Can one of the admins verify this patch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add missing
sincefor DSv2 APIWhy are the changes needed?
Let users know which version of the API was introduced.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
The change does not touch the code.