Conversation
Hello,
Hope you are well. We've been using DecisionTree at Samsung and hope to help in some small way. I was interested in setting the seed for the sampling i.e. in line 988. We're in the process of creating tests for our code being able to set the seed is helpful.
To that end, I think also the sample method here depends on a PartitionwiseSampledRDD. In there the 'compute' method think uses a different seed from the one that can be passed to the constructor of PartitionSampledRDD, it uses split.seed (below). Well hope we can discuss more! Thank you.. Best Wishes -Ed
override def compute(splitIn: Partition, context: TaskContext): Iterator[U] = {
val split = splitIn.asInstanceOf[PartitionwiseSampledRDDPartition]
val thisSampler = sampler.clone
thisSampler.setSeed(split.seed)
thisSampler.sample(firstParent[T].iterator(split.prev, context))
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Hope you are well. We've been using DecisionTree at Samsung and hope to help in some small way. I was interested in setting the seed for the sampling i.e. in line 988. We're in the process of creating tests for our code being able to set the seed is helpful.
To that end, I think also the sample method here depends on a PartitionwiseSampledRDD. In there the 'compute' method think uses a different seed from the one that can be passed to the constructor of PartitionSampledRDD, it uses split.seed (below). Well hope we can discuss more! Thank you.. Best Wishes -Ed
override def compute(splitIn: Partition, context: TaskContext): Iterator[U] = {
val split = splitIn.asInstanceOf[PartitionwiseSampledRDDPartition]
val thisSampler = sampler.clone
thisSampler.setSeed(split.seed)
thisSampler.sample(firstParent[T].iterator(split.prev, context))
}