[SPARK-38843][SQL] Fix translate metadata col filters#36126
Closed
wangyum wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-38843][SQL] Fix translate metadata col filters#36126wangyum wants to merge 1 commit intoapache:masterfrom
wangyum wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
cloud-fan
reviewed
Apr 12, 2022
| val pushedFilters = dataFilters | ||
| .flatMap(DataSourceStrategy.translateFilter(_, supportNestedPredicatePushdown)) | ||
| val pushedFilters = DataSourceStrategy.pushedDownFilters(dataFilters, fsRelation) | ||
| logInfo(s"Pushed Filters: ${pushedFilters.mkString(",")}") |
Contributor
There was a problem hiding this comment.
This is only used for logging. Can we move the logging into FileSourceScanExec?
Member
Author
There was a problem hiding this comment.
DataSourceStrategy.scala#L701-L706 also needs to ensure filter is pushable.
Contributor
|
The code looks a bit messy. How many times do we translate the filters during the entire query planning phase? |
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix translate metadata col filters because it can't be pushed down.
Before this PR:
spark/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/FileScanBuilder.scala
Line 78 in 128168d
https://github.com/apache/spark/blob/ac4f2af8d9184db3962427133ef2940c8b515c26/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala#L705
Why are the changes needed?
Fix bug.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing UT.