[SPARK-38854][PYTHON][TEST] Improve the test coverage for pyspark/statcounter.py #36145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pralabhkumar
force-pushed
the
rk_increase_coverage_statcounter
branch
from
6366c69 to
f45bcb3
Compare
Increasing code coverage for statcounter Added comments
pralabhkumar
force-pushed
the
rk_increase_coverage_statcounter
branch
from
f45bcb3 to
e1dd3e0
Compare
|
@HyukjinKwon My build is failing with "workflow run detection failed ". Can u please help me on the same |
|
Hm, not sure why it fails to detect. Seems your build is found here: https://github.com/pralabhkumar/spark/actions/runs/2150175269 |
HyukjinKwon
approved these changes
Apr 12, 2022
HyukjinKwon
reviewed
Apr 12, 2022
| self.assertEqual(stats.sum(), 20.0) | ||
| self.assertAlmostEqual(stats.variance(), 1.25) | ||
| self.assertAlmostEqual(stats.sampleVariance(), 1.4285714285714286) | ||
| for idx in range(2): |
There was a problem hiding this comment.
Can we create a list with:
stats1 = StatCounter([1.0, 2.0])
stats2 = StatCounter(range(1, 301))
stats = stats1.mergeStats(stats2) if idx == 1 else stats2.mergeStats(stats1)
and iterator with this for? Then I think we don't need to introduce this idx.
HyukjinKwon
reviewed
Apr 12, 2022
| # SPARK-38854: Test case to improve test coverage when | ||
| # StatCounter argument is empty list or None | ||
| arguments = [[], None] | ||
| import math |
There was a problem hiding this comment.
last nit. you can import this on the top of this file.
There was a problem hiding this comment.
@HyukjinKwon Done the changes as suggested
HyukjinKwon
approved these changes
Apr 12, 2022
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds a test for the case to check merge_stats when
Why are the changes needed?
To cover corner test cases and increase coverage
Does this PR introduce any user-facing change?
No - test only
How was this patch tested?
CI in this PR should test it out