Skip to content

[SPARK-38854][PYTHON][TEST] Improve the test coverage for pyspark/statcounter.py #36145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[SPARK-38854][PYTHON][TEST] Improve the test coverage for pyspark/statcounter.py #36145

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e1dd3e0
Increasing code coverage for statcounter
pralabhkumar Apr 11, 2022
07f8e50
Dummy push
pralabhkumar Apr 11, 2022
c76cb9b
Done the changes as suggested
pralabhkumar Apr 12, 2022
4d9a79a
Moved import to top of the file
pralabhkumar Apr 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions python/pyspark/tests/test_statcounter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
#
from pyspark.statcounter import StatCounter
from pyspark.testing.utils import ReusedPySparkTestCase
import math


class StatCounterTests(ReusedPySparkTestCase):
Expand Down Expand Up @@ -76,6 +77,31 @@ def test_merge_stats(self):
self.assertEqual(stats.sum(), 20.0)
self.assertAlmostEqual(stats.variance(), 1.25)
self.assertAlmostEqual(stats.sampleVariance(), 1.4285714285714286)
execution_statements = [
StatCounter([1.0, 2.0]).mergeStats(StatCounter(range(1, 301))),
StatCounter(range(1, 301)).mergeStats(StatCounter([1.0, 2.0])),
]
for stats in execution_statements:
self.assertEqual(stats.count(), 302)
self.assertEqual(stats.max(), 300.0)
self.assertEqual(stats.min(), 1.0)
self.assertAlmostEqual(stats.mean(), 149.51324503311)
self.assertAlmostEqual(stats.variance(), 7596.302804701549)
self.assertAlmostEqual(stats.sampleVariance(), 7621.539691095905)

def test_variance_when_size_zero(self):
# SPARK-38854: Test case to improve test coverage when
# StatCounter argument is empty list or None
arguments = [[], None]

for arg in arguments:
stats = StatCounter(arg)
self.assertTrue(math.isnan(stats.variance()))
self.assertTrue(math.isnan(stats.sampleVariance()))
self.assertEqual(stats.count(), 0)
self.assertTrue(math.isinf(stats.max()))
self.assertTrue(math.isinf(stats.min()))
self.assertEqual(stats.mean(), 0.0)

def test_merge_stats_with_self(self):
stats = StatCounter([1.0, 2.0, 3.0, 4.0])
Expand Down