[SPARK-38727][SQL][TESTS] Test the error class: FAILED_EXECUTE_UDF#36220
Closed
panbingkun wants to merge 7 commits intoapache:masterfrom
Closed
[SPARK-38727][SQL][TESTS] Test the error class: FAILED_EXECUTE_UDF#36220panbingkun wants to merge 7 commits intoapache:masterfrom
panbingkun wants to merge 7 commits intoapache:masterfrom
Conversation
MaxGekk
requested changes
Apr 17, 2022
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryExecutionErrorsSuite.scala
Outdated
Show resolved
Hide resolved
|
Can one of the admins verify this patch? |
MaxGekk
requested changes
Apr 18, 2022
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryExecutionErrorsSuite.scala
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryExecutionErrorsSuite.scala
Outdated
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryExecutionErrorsSuite.scala
Outdated
Show resolved
Hide resolved
MaxGekk
approved these changes
Apr 19, 2022
| } | ||
| } | ||
|
|
||
| test("INVALID_FRACTION_OF_SECOND: in the function make_timestamp") { |
Member
|
+1, LGTM. Merging to master. |
| val e2 = e1.getCause.asInstanceOf[SparkException] | ||
| assert(e2.getErrorClass === "FAILED_EXECUTE_UDF") | ||
| assert(e2.getMessage.matches("Failed to execute user defined function " + | ||
| "\\(QueryExecutionErrorsSuite\\$\\$Lambda\\$\\d+/\\d+: \\(string, int\\) => string\\)")) |
Member
There was a problem hiding this comment.
This seems to break Java 17 tests, @panbingkun and @MaxGekk . Please see the following community patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr aims to add one test for the error class FAILED_EXECUTE_UDF to QueryExecutionErrorsSuite.
Why are the changes needed?
The changes improve test coverage, and document expected error messages in tests.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
By running new test: