[SPARK-38742][SQL][TESTS] Move the tests MISSING_COLUMN from SQLQuerySuite to QueryCompilationErrorsSuite#36280
Closed
panbingkun wants to merge 6 commits intoapache:masterfrom
Closed
[SPARK-38742][SQL][TESTS] Move the tests MISSING_COLUMN from SQLQuerySuite to QueryCompilationErrorsSuite#36280panbingkun wants to merge 6 commits intoapache:masterfrom
MISSING_COLUMN from SQLQuerySuite to QueryCompilationErrorsSuite#36280panbingkun wants to merge 6 commits intoapache:masterfrom
Conversation
…pilationErrorsSuite
|
Can one of the admins verify this patch? |
MaxGekk
requested changes
Apr 22, 2022
…Suite to QueryCompilationErrorsSuite
Member
|
@panbingkun Could you resolve conflicts, please. |
Contributor
Author
Waiting for #36298 |
…Suite to QueryCompilationErrorsSuite
Contributor
Author
Done |
…Suite to QueryCompilationErrorsSuite
MaxGekk
reviewed
Apr 25, 2022
…Suite to QueryCompilationErrorsSuite
MaxGekk
approved these changes
Apr 25, 2022
Member
|
+1, LGTM. Merging to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr aims to move tests for the error class MISSING_COLUMN from SQLQuerySuite to QueryCompilationErrorsSuite, it's a followup of SPARK-37935.
Why are the changes needed?
To improve code maintenance.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
By running the moved tests: