[SPARK-38432][SQL][FOLLOWUP] Fix problems in And/Or/Not to V2 Filter#36290
Closed
huaxingao wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-38432][SQL][FOLLOWUP] Fix problems in And/Or/Not to V2 Filter#36290huaxingao wants to merge 1 commit intoapache:masterfrom
huaxingao wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
beliefer
approved these changes
Apr 21, 2022
Contributor
beliefer
left a comment
beliefer
left a comment
There was a problem hiding this comment.
LGTM. @huaxingao Thank you.
cloud-fan
approved these changes
Apr 21, 2022
Contributor
|
thanks, merging to master/3.3! |
cloud-fan
pushed a commit
that referenced
this pull request
Apr 21, 2022
### What changes were proposed in this pull request?
Instead of having
```
override def toV2: Predicate = new Predicate("AND", Seq(left, right).map(_.toV2).toArray)
```
I think we should construct a V2 `And` directly.
```
override def toV2: Predicate = new org.apache.spark.sql.connector.expressions.filter.And(left.toV2, right.toV2)
```
same for `Or` and `Not`.
### Why are the changes needed?
bug fixing
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
New tests
Closes #36290 from huaxingao/toV1.
Authored-by: huaxingao <huaxin_gao@apple.com>
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
(cherry picked from commit 36fc8bd)
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Contributor
Author
|
Thanks! @beliefer @cloud-fan |
lvshaokang
pushed a commit
to lvshaokang/spark
that referenced
this pull request
Apr 22, 2022
### What changes were proposed in this pull request?
Instead of having
```
override def toV2: Predicate = new Predicate("AND", Seq(left, right).map(_.toV2).toArray)
```
I think we should construct a V2 `And` directly.
```
override def toV2: Predicate = new org.apache.spark.sql.connector.expressions.filter.And(left.toV2, right.toV2)
```
same for `Or` and `Not`.
### Why are the changes needed?
bug fixing
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
New tests
Closes apache#36290 from huaxingao/toV1.
Authored-by: huaxingao <huaxin_gao@apple.com>
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Instead of having
I think we should construct a V2
Anddirectly.same for
OrandNot.Why are the changes needed?
bug fixing
Does this PR introduce any user-facing change?
No
How was this patch tested?
New tests