[SPARK-39147][SQL] Code simplification, use count() instead of filter().size, etc.#36507
Closed
morvenhuang wants to merge 5 commits intoapache:masterfrom
Closed
[SPARK-39147][SQL] Code simplification, use count() instead of filter().size, etc.#36507morvenhuang wants to merge 5 commits intoapache:masterfrom
morvenhuang wants to merge 5 commits intoapache:masterfrom
Conversation
HyukjinKwon
reviewed
May 11, 2022
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
Outdated
Show resolved
Hide resolved
srowen
approved these changes
May 11, 2022
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/StreamingJoinHelper.scala
Outdated
Show resolved
Hide resolved
HyukjinKwon
reviewed
May 11, 2022
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
Outdated
Show resolved
Hide resolved
Member
|
Oh I see, good catch! |
|
Can one of the admins verify this patch? |
Contributor
Author
|
The GC overhead limit exceeded error in AppVeyor build deesn't seem relevant. |
Member
|
Yes I'm confident it is not related. The others passed. Merged to master |
Contributor
Author
|
@srowen thank you Sean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use count() instead of filter().size, use df.count() instead of df.collect().size.
Why are the changes needed?
Code simplification.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.