[SPARK-39078][SQL] Fix a bug in UPDATE commands with DEFAULT values#36514
Closed
dtenedor wants to merge 2 commits intoapache:masterfrom
dtenedor:default-update-fix-bug
Closed
[SPARK-39078][SQL] Fix a bug in UPDATE commands with DEFAULT values#36514dtenedor wants to merge 2 commits intoapache:masterfrom dtenedor:default-update-fix-bug
dtenedor wants to merge 2 commits intoapache:masterfrom
dtenedor:default-update-fix-bug
Conversation
gengliangwang
approved these changes
May 12, 2022
Member
|
Thanks, merging to master |
|
Can one of the admins verify this patch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix a bug in UPDATE commands with DEFAULT values.
Specifically, the previous implementation of the
mapStructFieldNamesToExpressionsmethod associated column names with default values in the order of the keys inMap[String, StructField]. Since that's not always true, this PR updates that method to consume these columns in the order they actually appear in the target table schema instead.Why are the changes needed?
The bug is fixed with this PR.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
An extra test exercises an error case that failed before, but is now fixed.