[SPARK-39187][SQL][3.3] Remove SparkIllegalStateException#36558
Closed
MaxGekk wants to merge 1 commit intoapache:branch-3.3from
Closed
[SPARK-39187][SQL][3.3] Remove SparkIllegalStateException#36558MaxGekk wants to merge 1 commit intoapache:branch-3.3from
SparkIllegalStateException#36558MaxGekk wants to merge 1 commit intoapache:branch-3.3from
Conversation
Remove `SparkIllegalStateException` and replace it by `IllegalStateException` where it was used. To improve code maintenance and be consistent to other places where `IllegalStateException` is used in illegal states (for instance, see apache#36524). After the PR apache#36500, the exception is substituted by `SparkException` w/ the `INTERNAL_ERROR` error class. No. Users shouldn't face to the exception in regular cases. By running the affected test suites: ``` $ build/sbt "sql/test:testOnly *QueryExecutionErrorsSuite*" $ build/sbt "test:testOnly *ArrowUtilsSuite" ``` Closes apache#36550 from MaxGekk/remove-SparkIllegalStateException. Authored-by: Max Gekk <max.gekk@gmail.com> Signed-off-by: Max Gekk <max.gekk@gmail.com> (cherry picked from commit 1a90512) Signed-off-by: Max Gekk <max.gekk@gmail.com>
HyukjinKwon
approved these changes
May 16, 2022
Member
Author
|
Merging to 3.3. Thank you, @HyukjinKwon for review. |
MaxGekk
added a commit
that referenced
this pull request
May 16, 2022
### What changes were proposed in this pull request? Remove `SparkIllegalStateException` and replace it by `IllegalStateException` where it was used. This is a backport of #36550. ### Why are the changes needed? To improve code maintenance and be consistent to other places where `IllegalStateException` is used in illegal states (for instance, see #36524). After the PR #36500, the exception is substituted by `SparkException` w/ the `INTERNAL_ERROR` error class. ### Does this PR introduce _any_ user-facing change? No. Users shouldn't face to the exception in regular cases. ### How was this patch tested? By running the affected test suites: ``` $ build/sbt "sql/test:testOnly *QueryExecutionErrorsSuite*" $ build/sbt "test:testOnly *ArrowUtilsSuite" ``` Authored-by: Max Gekk <max.gekkgmail.com> Signed-off-by: Max Gekk <max.gekkgmail.com> (cherry picked from commit 1a90512) Signed-off-by: Max Gekk <max.gekkgmail.com> Closes #36558 from MaxGekk/remove-SparkIllegalStateException-3.3. Authored-by: Max Gekk <max.gekk@gmail.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove
SparkIllegalStateExceptionand replace it byIllegalStateExceptionwhere it was used.This is a backport of #36550.
Why are the changes needed?
To improve code maintenance and be consistent to other places where
IllegalStateExceptionis used in illegal states (for instance, see #36524). After the PR #36500, the exception is substituted bySparkExceptionw/ theINTERNAL_ERRORerror class.Does this PR introduce any user-facing change?
No. Users shouldn't face to the exception in regular cases.
How was this patch tested?
By running the affected test suites:
Authored-by: Max Gekk max.gekk@gmail.com
Signed-off-by: Max Gekk max.gekk@gmail.com
(cherry picked from commit 1a90512)
Signed-off-by: Max Gekk max.gekk@gmail.com