[SPARK-39204][CORE][SQL] Replace Utils.createTempDir with JavaUtils.createTempDir#36610
Closed
LuciferYang wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-39204][CORE][SQL] Replace Utils.createTempDir with JavaUtils.createTempDir#36610LuciferYang wants to merge 2 commits intoapache:masterfrom
Utils.createTempDir with JavaUtils.createTempDir#36610LuciferYang wants to merge 2 commits intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This main change of this pr is replace all use of
Utils.createTempDirwithJavaUtils.createTempDir, the replacement rules are as follows:Utils.createTempDir()->JavaUtils.createTempDir()Utils.createTempDir(rootDir)andUtils.createTempDir(root = rootDir)->JavaUtils.createTempDirWithRoot(rootDir)Utils.createTempDir(namePrefix = prefix)->JavaUtils.createTempDirWithPrefix(prefix)Utils.createTempDir(rootDir, prefix)->JavaUtils.createTempDir(rootDir, prefix)Another change is to delete
Utils.createTempDir()method to keep only onecreateTempDir()method.Why are the changes needed?
Keep only one
createTempDir()method in Spark.Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GitHub Action.